Ethereal-dev: Re: [Ethereal-dev] Unused function parameters: Request for help

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: "Dr. Uwe Girlich" <Uwe.Girlich@xxxxxxxxxxx>
Date: Tue, 2 Apr 2002 08:48:33 +0200
On Mon, Apr 01, 2002 at 03:46:37PM -0800, Guy Harris wrote:
> I guess the questions are, for the low-level RPC item dissector
> routines:
> 	1) whether we'd ever expect them to need anything from "pinfo"
> 	   (I suspect they'd never use it to add stuff to the Info column,
> 	   as they're probably too low-level to know enough about what
> 	   they're dissecting to put a high-enough-level description in the
> 	   Info column; I'm not sure they'd ever need it for anything else,
> 	   either);
The low-level functions don't use pinfo at all. It can be removed almost
everywhere.

> 	2) if not, whether we'd want to bite the bullet and just change
> 	   them and all its callers.
I'm just doing this. packet-rpc.c & packet-rpc.h are ready but I can't check
them in before changing all callers too (it would break compiling for too long).

Uwe