Ethereal-dev: Re: [Ethereal-dev] Unused function parameters: Request for help

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Tue, 2 Apr 2002 01:28:11 +0200
I don't think that removing the unused variables would be helpful: The
function types would change (some of which are used in packet-hclnfsd.c).

Changelog: <jmayer@xxxxxxxxx>
	- packet-hclnfsd.c, packet-rpc.c
	  Flag unused pinfo parameters with _U_
	- remove one unused variable

--
Joerg Mayer                                          <jmayer@xxxxxxxxx>
I found out that "pro" means "instead of" (as in proconsul). Now I know
what proactive means.
Index: ethereal/packet-hclnfsd.c
===================================================================
RCS file: /cvsroot/ethereal/packet-hclnfsd.c,v
retrieving revision 1.11
diff -u -r1.11 packet-hclnfsd.c
--- packet-hclnfsd.c	2002/04/01 22:40:20	1.11
+++ packet-hclnfsd.c	2002/04/01 23:10:16
@@ -87,7 +87,7 @@
 static gint ett_hclnfsd_auth_ident = -1;
 
 static int
-dissect_hclnfsd_gids(tvbuff_t *tvb, int offset, packet_info *pinfo, proto_tree *tree)
+dissect_hclnfsd_gids(tvbuff_t *tvb, int offset, packet_info *pinfo _U_, proto_tree *tree)
 {
 	guint32 ngids, ngids_i, gid;
 	proto_tree *gidtree = NULL;
@@ -295,7 +295,7 @@
 
 
 static int
-dissect_hclnfsd_return_host_call(tvbuff_t *tvb, int offset, packet_info *pinfo, proto_tree *tree)
+dissect_hclnfsd_return_host_call(tvbuff_t *tvb, int offset, packet_info *pinfo _U_, proto_tree *tree)
 {
 	proto_tree_add_item(tree, hf_hclnfsd_host_ip, tvb, offset, 4, FALSE);
 	offset += 4;
Index: ethereal/packet-rpc.c
===================================================================
RCS file: /cvsroot/ethereal/packet-rpc.c,v
retrieving revision 1.88
diff -u -r1.88 packet-rpc.c
--- packet-rpc.c	2002/03/27 04:27:03	1.88
+++ packet-rpc.c	2002/04/01 23:10:26
@@ -426,7 +426,7 @@
 
 
 int
-dissect_rpc_bool(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
+dissect_rpc_bool(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree,
 int hfindex, int offset)
 {
 	if (tree)
@@ -436,7 +436,7 @@
 
 
 int
-dissect_rpc_uint32(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
+dissect_rpc_uint32(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree,
 int hfindex, int offset)
 {
 	if (tree)
@@ -446,7 +446,7 @@
 
 
 int
-dissect_rpc_uint64(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
+dissect_rpc_uint64(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree,
 int hfindex, int offset)
 {
 	header_field_info	*hfinfo;
@@ -461,7 +461,7 @@
 
 
 static int
-dissect_rpc_opaque_data(tvbuff_t *tvb, int offset, packet_info *pinfo,
+dissect_rpc_opaque_data(tvbuff_t *tvb, int offset, packet_info *pinfo _U_,
     proto_tree *tree, int hfindex, gboolean string_data,
     char **string_buffer_ret)
 {
@@ -806,8 +806,8 @@
 }
 
 int
-dissect_rpc_authdes_desblock(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
-int hfindex, int offset)
+dissect_rpc_authdes_desblock(tvbuff_t *tvb, packet_info *pinfo _U_,
+proto_tree *tree, int hfindex, int offset)
 {
 	guint32 value_low;
 	guint32 value_high;
@@ -2287,7 +2287,6 @@
 	conversation_t *conversation;
 	fragment_data *ipfd_head;
 	tvbuff_t *rec_tvb;
-	fragment_data *ipfd;
 
 	/*
 	 * Get the record mark.