Ethereal-dev: Re: [Ethereal-dev] Unused function parameters: Request for help

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Tue, 2 Apr 2002 01:23:03 +0200
On Sun, Mar 31, 2002 at 05:51:44PM -0800, Guy Harris wrote:
> *OR* use the parameters, if that's the appropriate fix!  See below.

Right. I missed that one.

> I.e., one shouldn't blindly either remove unused arguments or flag them
> with _U_; one should first ascertain whether the argument *should*, in
> fact, be used.

> > Main programs, tools and libs:
> 
> 	...
> 
> >       4	grammar.c
> 
> 	...
> 
> That's a generated file; unfortunately, Lemon doesn't make it easy to
> put _U_ (or any other string) into the declaration or definition of the
> function in question.

IIRC I included a patch to lemon.c to add the _U_ there, as it is our modified
copy of it anyway. Thinking about that now I think you were right not to
apply that patch - it's a hack. I think there are some warnings we should
just leave as a reminder.

Btw. I have started looking at the capture_... functions. Not all of them
are called with all parameters. Would you prefer to have identical parameter
lists with some _U_ in the headers or individually shortened parameter lists?

   Ciao
             Jï¿œrg
--
Joerg Mayer                                          <jmayer@xxxxxxxxx>
I found out that "pro" means "instead of" (as in proconsul). Now I know
what proactive means.