Ethereal-dev: Re: [Ethereal-dev] packet-sccp.c patch for compilation under Win32

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Gilbert Ramirez <gram@xxxxxxxxxxxxxxx>
Date: 06 Mar 2002 11:55:23 -0600
On Wed, 2002-03-06 at 11:39, David Frascone wrote:
> 
> 
> On Wednesday, 06 Mar 2002, Jeff Morriss wrote:
> > 
> > Actually, that patch will break the intended functionality :(.
> > 
> > Does the attached patch fix VC++'s complaint?
> > 
> > If not, the offending statement should be broken into:
> > 
> > if (called)
> > 	called_ssn = ssn;
> > else
> > 	calling_ssn = ssn;
> 
> That might have been the intended functionality, but it is definately 
> *not* what the code was doing, before *or* after the patch.
> 
> Looks like the code being more readable made a bug more obvious.  Go
> figure.
> 

Indeed. I'm checking in this clearer and correct version.

thanks,

--gilbert