Ethereal-dev: Re: [Ethereal-dev] packet-sccp.c patch for compilation under Win32

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: David Frascone <dave@xxxxxxxxxxxx>
Date: Wed, 6 Mar 2002 11:39:41 -0600
On Wednesday, 06 Mar 2002, Jeff Morriss wrote:
> 
> Actually, that patch will break the intended functionality :(.
> 
> Does the attached patch fix VC++'s complaint?
> 
> If not, the offending statement should be broken into:
> 
> if (called)
> 	called_ssn = ssn;
> else
> 	calling_ssn = ssn;

That might have been the intended functionality, but it is definately 
*not* what the code was doing, before *or* after the patch.

Looks like the code being more readable made a bug more obvious.  Go
figure.

-Dave