On Tue, 29 Jan 2002 09:49:04 Joe Litman wrote:
> Hi
> There are some minor bugs in the h261 dissector.
> Line numbers refer to revision 1.12 of packet-h261.c
>
> Line 92 proto_tree_add_item should be proto_tree_add_uint
> Otherwise the value displayed for ebits is the value of the entire byte
> instead of just the 3 bits that make up ebit
>
> Line 108 The second argument to proto_tree_add_uint should be hf_h261_quant
> instead of hf_h261_mbap. hf_h261_mbap was already displayed, see Line 102.
>
> Line 110 The second argument to proto_tree_add_uint should be hf_h261_hmvd
> instead of hf_h261_mbap. hf_h261_mbap was already displayed, see Line 102.
And the comment above it should read HMVD isntead of HMDV.
> Line 116 The second argument to proto_tree_add_uint should be hf_h261_vmvd
> instead of hf_h261_mbap. hf_h261_mbap was already displayed, see Line 102.
>
> I wasn't sure how best to provide this information to you. If this is not
> sufficient please let me know what you require.
>
That's fine; I checked in the changes. A diff file would have
been just a tad easier to work with; but since there were so few changes
in your message, it wasn't difficult work.
thanks,
--gilbert