Nice work.
Some comments though
1, a lot of the fields handled lacks any hf_* definitions and just use
proto_tree_add_text
2, instead of the massive switch statements for finding the correct
subdissector perhaps you should
make it table driven, as for example ndmp and other dissectors are.
----- Original Message -----
From: <ddutt@xxxxxxxxx>
To: <ethereal-dev@xxxxxxxxxxxx>
Sent: Thursday, January 10, 2002 11:40 AM
Subject: [Ethereal-dev] SCSI Decoder
> Folks,
>
> Here is the SCSI decoder that I promised last week. There are three files
in
> the tar:
> packet-scsi.[ch]
> cvs diff output for packet-iscsi.c
>
> Right now, the decoder doesn't decode the details of SCSI tape devices,
just
> disks (SBC2) and SCSI Primary commands (SPC2). I plan to add support for
adding
> detailed decoding of tapes shortly.
>
> Enjoy,
>
> Dinesh
> --
>
----------------------------------------------------------------------------
----
>
> --
> A hundred times every day I remind myself that my inner and outer life
depend
> on the labors of other men, living and dead, and that I must exert myself
in
> order to give in the same measure as I have received and am still
receiving.
> - Albert
Einstein