Ethereal-dev: Re: [Ethereal-dev] TCP fields in higher-level protocols

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Thu, 28 Dec 2000 02:26:29 -0800
On Thu, Dec 28, 2000 at 11:30:28AM +1030, Glen Turner wrote:
> NDE has fields like the TCP DiffServ octet and the
> TCP flags.
> 
> My current dissector has a copy of the code from the
> TCP dissector to dissect these.
> 
> Should I instead be altering packet-tcp to make the
> routines to do the dissection into globally-usable
> functions and then call these from packet-nde?

That's probably not a bad idea; another alternative might be to do what
was done for the xDLC protocols and put them into a separate file, but
those routines are probably not as likely to be widely used as is the
xDLC control field (used by LAPB, LAPD, V.120, and 802.2 LLC), so
keeping them in the TCP (and IP? which TCP DiffServ octet is that?)
dissector is probably OK.