Ethereal-dev: Re: [Ethereal-dev] SIP update, use tvb_find_line_end()

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <guy@xxxxxxxxxx>
Date: Tue, 14 Nov 2000 14:37:14 -0800 (PST)
> Looks like packet-ipsec.c is currently the only real user for
> col_set_writeable().

Currently - but once we've tvbuffified all the dissectors, and can thus
at least consider having the ICMP dissector call the IP dissector on the
small chunk of IP datagram in some ICMP replies, the ICMP dissector
should also make the columns non-writable before calling the IP
dissector, so that the frame looks, in the summary, like an ICMP frame,
not like a packet of the type that provoked the ICMP error.