Ethereal-dev: Re: [ethereal-dev] pptp error?

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Wed, 19 Jan 2000 23:14:12 -0800
Yes, it does appear to be screwage from an oh-so-"helpful" Web browser
or Web server - tabs got turned into spaces.  I'll try using "wget" and
see if that works better.

There *is* one bug in the patch - it changes     

	proto_tree_add_text(pptp_tree, offset, sizeof(hdr->len),
                       "Length: %u", len);

to

        proto_tree_add_text(pptp_tree, offset, sizeof(hdr->len),
                       "Length: %u", ntohs (len));

but "len" was fetched with "pntohs()", so it's *already* in host byte
order.