Ethereal-dev: Re: [ethereal-dev] pptp error?

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Wed, 19 Jan 2000 23:11:53 -0800
> Not knowing PPTP, I have to ask, does this change look valid?

RFC 2637, the PPTP RFC, says fields in PPTP packets are in network byte
order, so that part is correct.

The change, however, appears to convert code that dereferences
possibly-unaligned pointers to code that dereferences possibly-unaligned
pointers and then puts the result in network byte order, so it's not the
right way to fix the problem - the right way is to use "pntohs()" and
"pntohl()".

The patch didn't apply very well - I don't know if that's because I got
screwed, once again, by a mail archive accessed via a Web browser, or
not.  I'll put in the changes by hand.