Wireshark-users: Re: [Wireshark-users] Build wireshark on windows fails, linux works

From: Marcel Sicking <Marcel.Sicking@xxxxxxxxxxx>
Date: Fri, 26 Mar 2010 16:28:49 +0100
Hi,
thanks a lot for the answers.
When I will implement my own patch, I can have a look at the syntax.
But this is a bit difficult when I need to implement a patch from someone else.
Maybe I can modify the patch to get it compiled with MSVC.
Regards,
Marcel



OnePhone
Marcel Sicking - Core Network Engineer

Tel: +49 (211) 5423 5010
Mobil: +49 (1577) 540 5010
Fax: +49 (211) 5423 5099
E-Mail: Marcel.Sicking@xxxxxxxxxxx
Web: http://www.onephone.de/

OnePhone Deutschland GmbH
Duesseldorfer Str. 16
40699 Erkrath, Deutschland

Geschaeftsfuehrer: Marc Mauermann
Sitz der Gesellschaft: Erkrath, Duesseldorfer Str.16, D-40699 Erkrath
HRB 21674 Wuppertal

-----Ursprüngliche Nachricht-----
Von: Guy Harris [mailto:guy@xxxxxxxxxxxx]
Gesendet: Donnerstag, 25. März 2010 18:56
An: Community support list for Wireshark
Betreff: Re: [Wireshark-users] Build wireshark on windows fails, linux works


On Mar 25, 2010, at 4:21 AM, Marcel Sicking wrote:

> Lines are:
>
> static const struct tlv_definition rsl_att_tlvdef = {
>     .def = {                                                                                        #650
>         [RSL_IE_CH_NO]            = { TLV_TYPE_TV, 0 },
>         [RSL_IE_LINK_ID]        = { TLV_TYPE_TV, 0 },
>         [RSL_IE_ACT_TYPE]        = { TLV_TYPE_TV, 0 },
>
>         [RSL_IE_IPAC_CONN_ID]        = { TLV_TYPE_FIXED, 2 },
>         [RSL_IE_IPAC_RTP_PAYLOAD2]    = { TLV_TYPE_TV, 0 },
>     },                                                                                                            #718
> };

That's not supported by Microsoft's C compiler.

> Can somebody help me?

Use only those non-C89 features that are supported by GCC *and* MSVC in your dissector.  (Yes, C89, not C99; Microsoft's C compiler doesn't support all of C99.)

If you want to submit your changes to us, read the doc/README.developer section on "Portability" - there are other compilers to worry about as well in a program that has to build with native compilers on a number of different UN*Xes as well as with MSVC on Windows.
___________________________________________________________________________
Sent via:    Wireshark-users mailing list <wireshark-users@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-users
Unsubscribe: https://wireshark.org/mailman/options/wireshark-users
             mailto:wireshark-users-request@xxxxxxxxxxxxx?subject=unsubscribe