so I think it would be worth doing. I'm happy to look at this (or
something simpler by only looking for PSNAME?), but it might be a few days
before I get to it.
Thanks again,
Martin
On Tue, Feb 3, 2026 at 8:48=E2=80=AFAM Tam=C3=A1s Reg=C5=91s <regost@gmail.=
com> wrote:
> Hi Martin,
>
> "Words that appear as the name of a dissector/protocol should not be
> reported (the script checks for proto_register_protocol() calls and adds
> them to the dict)"...
> I am not entirely sure it works that way.
>
> In my case:
>
> packet-qcdiag.c
> #define PNAME "Qualcomm Diagnostic"
> #define PSNAME "QCDIAG"
> #define PFNAME "qcdiag"
> ...
> proto_qcdiag =3D proto_register_protocol(PNAME, PSNAME, PFNAME);
>
> example "Clang + Code Checks" (passed):
> https://gitlab.com/infostam/wireshark/-/jobs/12947400694
>
> epan/dissectors/packet-qcdiag.c 10 / 3922 "packet-qcdiag.c" qcdiag -> ?
> ...
> epan/dissectors/packet-qcdiag.c 3902 / 3922 "qcdiag.ext_build_id.ver"
> qcdiag -> ?
> epan/dissectors/packet-qcdiag.c 3904 / 3922 "qcdiag.ext_build_id.res"
> qcdiag -> ?
> epan/dissectors/packet-qcdiag.c 3906 / 3922 "qcdiag.ext_build_id.msm"
> qcdiag -> ?
> epan/dissectors/packet-qcdiag.c 3909 / 3922
> "qcdiag.ext_build_id.mob_model" qcdiag -> ?
> epan/dissectors/packet-qcdiag.c 3912 / 3922 "qcdiag.ext_build_id.sw_rev"
> qcdiag -> ?
> epan/dissectors/packet-qcdiag.c 3914 / 3922
> "qcdiag.ext_build_id.mob_model_str" qcdiag -> ?
> epan/dissectors/packet-qcdiag.c 3915 / 3922 "qcdiag.cmd" qcdiag -> ?
> epan/dissectors/packet-qcdiag.c 3916 / 3922 "QCDIAG Command" QCDIAG -> ?
> epan/dissectors/packet-qcdiag.c 3917 / 3922 "qcdiag.subsys_id" qcdiag -> =
?
> epan/dissectors/packet-qcdiag.c 3918 / 3922 "QCDIAG Subsystem" QCDIAG -> =
?
>
> qcdiag : 43
>
> If I add "qcdiag" to wireshark_words.txt, these lines disappear...
>
> What do you think?
>
> I will raise the MRs.
>
> Regards,
> Tamas
>
> On Tue, 3 Feb 2026 at 15:37, Martin Mathieson via Wireshark-dev <
> wireshark-dev@xxxxxxxxxxxxx> wrote:
>
>> Yes, of course. A quick check for where 'len(word)' appears in
>> tools/check_spelling.py - I think words < 5 characters won't be reported
>> anyway, so some of the ones you mention would be too short.
>>
>> Words that appear as the name of a dissector/protocol should not be
>> reported (the script checks for proto_register_protocol() calls and adds
>> them to the dict), although the order that files are checked can obvious=
ly
>> affect whether or not they have already been loaded.
>>
>> I see your other email about tools/check_spelling.py next - I was a
>> little hasty in making these checking tools use concurrent.futures - the
>> speedup is amazing though :)
>> Your help in fixing this would be much appreciated.
>>
>> Martin
>>
>> On Tue, Feb 3, 2026 at 7:57=E2=80=AFAM Tam=C3=A1s Reg=C5=91s <regost@gma=
il.com> wrote:
>>
>>> Hi Dev Team,
>>>
>>> Is it OK to submit an MR for updating tools/wireshark_words.txt file
>>> with some words?
>>>
>>> For example: gsm, gsmtap, lte, nr, rrc, umts, wcdma?
>>>
>>> Regards,
>>> Tamas
>>> _______________________________________________
>>> Wireshark-dev mailing list -- wireshark-dev@xxxxxxxxxxxxx
>>> To unsubscribe send an email to wireshark-dev-leave@xxxxxxxxxxxxx
>>>
>> _______________________________________________
>> Wireshark-dev mailing list -- wireshark-dev@xxxxxxxxxxxxx
>> To unsubscribe send an email to wireshark-dev-leave@xxxxxxxxxxxxx
>>
> _______________________________________________
> Wireshark-dev mailing list -- wireshark-dev@xxxxxxxxxxxxx
> To unsubscribe send an email to wireshark-dev-leave@xxxxxxxxxxxxx
>
--000000000000acd96d0649e845a7
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">Hi Tamas,<div><br></div><div>Most dissectors use literals =
instead of PSNAME, etc - which I think I prefer.</div><div><br></div><div>H=
owever, we could try:</div><div>- moving find_macros() from check_typed_ite=
m_calls.py to check_common.py and use that.=C2=A0 It looks for simple #defi=
ne and also matches (some) enums - has been used to get numerical values so=
far</div><div>- have check_spelling.py also call that function, and attemp=
t to substitute for the psname arg if it isn't a literal string?</div><=
div><br></div><div>From epan/dissectors:</div><div>grep proto_register_prot=
ocol *.c | grep PSNAME | wc -l<br>169</div><div><br></div><div>so I think i=
t would be worth doing.=C2=A0 I'm happy to look at this (or something s=
impler by only looking for PSNAME?), but it might be a few days before I ge=
t to it.</div><div><br></div><div>Thanks again,</div><div>Martin</div></div=
><br><div class=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr" clas=
s=3D"gmail_attr">On Tue, Feb 3, 2026 at 8:48=E2=80=AFAM Tam=C3=A1s Reg=C5=
=91s <<a href=3D"mailto:regost@xxxxxxxxx";>regost@xxxxxxxxx</a>> wrote=
:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.=
8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"lt=
r"><div>Hi Martin,</div><div><br></div><div>"Words that appear as the =
name of a dissector/protocol should not be reported (the script checks for=
=C2=A0proto_register_protocol() calls and adds them to the dict)"...</=
div><div>I am not entirely sure it works that way.=C2=A0</div><div><br></di=
v><div>In my case:</div><div><br></div><div>packet-qcdiag.c</div><div><font=
face=3D"monospace">#define PNAME =C2=A0"Qualcomm Diagnostic"<br>=
#define PSNAME "QCDIAG"<br>#define PFNAME "qcdiag"</fon=
t><br></div><div><font face=3D"monospace">...</font></div><div><font face=
=3D"monospace">proto_qcdiag =3D proto_register_protocol(PNAME, PSNAME, PFNA=
ME);</font></div><div><br></div><div>example "Clang + Code Checks"=
; (passed):</div><div><a href=3D"https://gitlab.com/infostam/wireshark/-/jo=
bs/12947400694" target=3D"_blank">https://gitlab.com/infostam/wireshark/-/j=
obs/12947400694</a></div><div><br></div><div><font face=3D"monospace">epan/=
dissectors/packet-qcdiag.c 10 / 3922 "packet-qcdiag.c" qcdiag -&g=
t; =C2=A0?</font></div><div><font face=3D"monospace">...</font></div><div><=
font face=3D"monospace">epan/dissectors/packet-qcdiag.c 3902 / 3922 "q=
cdiag.ext_build_id.ver" qcdiag -> =C2=A0?<br>epan/dissectors/packet=
-qcdiag.c 3904 / 3922 "qcdiag.ext_build_id.res" qcdiag -> =C2=
=A0?<br>epan/dissectors/packet-qcdiag.c 3906 / 3922 "qcdiag.ext_build_=
id.msm" qcdiag -> =C2=A0?<br>epan/dissectors/packet-qcdiag.c 3909 /=
3922 "qcdiag.ext_build_id.mob_model" qcdiag -> =C2=A0?<br>epa=
n/dissectors/packet-qcdiag.c 3912 / 3922 "qcdiag.ext_build_id.sw_rev&q=
uot; qcdiag -> =C2=A0?<br>epan/dissectors/packet-qcdiag.c 3914 / 3922 &q=
uot;qcdiag.ext_build_id.mob_model_str" qcdiag -> =C2=A0?<br>epan/di=
ssectors/packet-qcdiag.c 3915 / 3922 "qcdiag.cmd" qcdiag -> =
=C2=A0?<br>epan/dissectors/packet-qcdiag.c 3916 / 3922 "QCDIAG Command=
" QCDIAG -> =C2=A0?<br>epan/dissectors/packet-qcdiag.c 3917 / 3922 =
"qcdiag.subsys_id" qcdiag -> =C2=A0?<br>epan/dissectors/packet=
-qcdiag.c 3918 / 3922 "QCDIAG Subsystem" QCDIAG -> =C2=A0?</fo=
nt></div><div><font face=3D"monospace"><br></font></div><div><font face=3D"=
monospace">qcdiag : 43</font></div><div><br></div><div><div>If I add "=
qcdiag" to wireshark_words.txt, these lines disappear...</div><div></d=
iv></div><div><br></div><div>What do you think?</div><div><br></div><div>I =
will raise the MRs.</div><div><br></div><div>Regards,</div><div>Tamas</div>=
</div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">=
On Tue, 3 Feb 2026 at 15:37, Martin Mathieson via Wireshark-dev <<a href=
=3D"mailto:wireshark-dev@xxxxxxxxxxxxx"; target=3D"_blank">wireshark-dev@wir=
eshark.org</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr">Yes, of course. A quick check =
for where 'len(word)' appears in tools/check_spelling.py - I think =
words < 5 characters won't be reported anyway, so some of the ones y=
ou mention would be too short.<div><br></div><div>Words that appear as the =
name of a dissector/protocol should not be reported (the script checks for=
=C2=A0proto_register_protocol() calls and adds them to the dict), although =
the order that files are checked can obviously affect whether or not they h=
ave already been loaded.</div><div><br></div><div>I see your other email ab=
out tools/check_spelling.py next - I was a little hasty in making these che=
cking tools use concurrent.futures - the speedup is amazing though :)</div>=
<div>Your help in fixing this would be much appreciated.</div><div><br></di=
v><div>Martin=C2=A0</div></div></div><br><div class=3D"gmail_quote"><div di=
r=3D"ltr" class=3D"gmail_attr">On Tue, Feb 3, 2026 at 7:57=E2=80=AFAM Tam=
=C3=A1s Reg=C5=91s <<a href=3D"mailto:regost@xxxxxxxxx"; target=3D"_blank=
">regost@xxxxxxxxx</a>> wrote:<br></div><blockquote class=3D"gmail_quote=
" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);=
padding-left:1ex"><div dir=3D"ltr">Hi Dev Team,<div><br></div><div>Is it OK=
to submit an MR for updating tools/wireshark_words.txt file with some word=
s?</div><div><br></div><div>For example: gsm, gsmtap, lte, nr, rrc, umts, w=
cdma?</div><div><br></div><div>Regards,</div><div>Tamas</div></div>
_______________________________________________<br>
Wireshark-dev mailing list -- <a href=3D"mailto:wireshark-dev@xxxxxxxxxxxxx=
" target=3D"_blank">wireshark-dev@xxxxxxxxxxxxx</a><br>
To unsubscribe send an email to <a href=3D"mailto:wireshark-dev-leave@wires=
hark.org" target=3D"_blank">wireshark-dev-leave@xxxxxxxxxxxxx</a><br>
</blockquote></div>
_______________________________________________<br>
Wireshark-dev mailing list -- <a href=3D"mailto:wireshark-dev@xxxxxxxxxxxxx=
" target=3D"_blank">wireshark-dev@xxxxxxxxxxxxx</a><br>
To unsubscribe send an email to <a href=3D"mailto:wireshark-dev-leave@wires=
hark.org" target=3D"_blank">wireshark-dev-leave@xxxxxxxxxxxxx</a><br>
</blockquote></div>
_______________________________________________<br>
Wireshark-dev mailing list -- <a href=3D"mailto:wireshark-dev@xxxxxxxxxxxxx=
" target=3D"_blank">wireshark-dev@xxxxxxxxxxxxx</a><br>
To unsubscribe send an email to <a href=3D"mailto:wireshark-dev-leave@wires=
hark.org" target=3D"_blank">wireshark-dev-leave@xxxxxxxxxxxxx</a><br>
</blockquote></div>
--000000000000acd96d0649e845a7--