Wireshark-dev: [Wireshark-dev] Re: Installed protocol header file cleanup

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Maksim Dmitrichenko <dmitrmax@xxxxxxxxx>
Date: Sun, 14 Dec 2025 16:31:26 +0400
Hi, Gerald!

пт, 12 дек. 2025 г. в 23:59, Gerald Combs via Wireshark-dev
<wireshark-dev@xxxxxxxxxxxxx>:
> However it might also remove a less obvious header that you depend on. If that's the case, you can add it back by opening a merge request that marks it as a public header using a comment, e.g.
>
>      // PUBLIC_HEADER: This is used for a custom dissector for [foo]

Is there any additional action needed except adding the comment? I've
created an MR: https://gitlab.com/wireshark/wireshark/-/merge_requests/22766
and its pipeline failed because some check was not passed but I can't
figure it out from the logs.


-- 
With best regards
  Maksim Dmitrichenko