[Jaap Keuter <jaap.keuter@xxxxxxxxx>]

Hi,

Ah, never mind, the function (asterix_parse_re_field) is used from the code in the generated packet-asterix-generated.h file. 

I don’t like code in “.h” files. The fact that you pull in code using #include doesn’t automatically make it a header file.

Thanks,

Jaap

On 6 Oct 2025, at 07:15, Jaap Keuter via Wireshark-dev <wireshark-dev@xxxxxxxxxxxxx> wrote:

Hi,

Well, yes of course, that takes care of that problem, which eventually would need to be done.

OTOH, does this then result in a dead-code warning? Maybe not from the compiler, but then from static code analysis.

So this was more to see what would happen then.

Thanks,

Jaap

On 5 Oct 2025, at 22:23, Timo Warns <timo.warns@xxxxxxxxx> wrote:

For what it's worth, a fix (initializing table_p with 0s) is part of
https://gitlab.com/wireshark/wireshark/-/merge_requests/21669

Regards, Timo

Am So., 5. Okt. 2025 um 21:48 Uhr schrieb Jaap Keuter via Wireshark-dev <wireshark-dev@xxxxxxxxxxxxx>:

Hi,

Well, you might as well remove that function (asterix_parse_re_field) from compilation, since it doesn’t seem to be used…

Thanks,

Jaap

On 5 Oct 2025, at 21:34, Yaniv Kaul <yaniv.kaul@xxxxxxxxxxxx> wrote:

On Sun, Oct 5, 2025 at 8:41 PM Jaap Keuter via Wireshark-dev <wireshark-dev@xxxxxxxxxxxxx> wrote:

Hi,

What happens if you pull again?

Pulled as hard as I could. No go.

Y.

 

Thanks,
Jaap


> On 5 Oct 2025, at 15:43, Yaniv Kaul via Wireshark-dev <wireshark-dev@xxxxxxxxxxxxx> wrote:
> 
> Failure:
> /home/ykaul/github/wireshark/epan/dissectors/packet-asterix.c: In function ‘asterix_parse_re_field.constprop’:
> /home/ykaul/github/wireshark/epan/dissectors/packet-asterix.c:290:44: error: ‘table_p.table_pointer’ may be used uninitialized [-Werror=maybe-uninitialized]
>   290 |             offset += table_p.table_pointer[i](tvb, offset, tree, expand_value);
>       |                       ~~~~~~~~~~~~~~~~~~~~~^~~
> /home/ykaul/github/wireshark/epan/dissectors/packet-asterix.c:278:18: note: ‘table_p.table_pointer’ was declared here
>   278 |     table_params table_p;
>       |                  ^~~~~~~
> /home/ykaul/github/wireshark/epan/dissectors/packet-asterix.c:284:18: error: ‘table_p.table_pointer_expand’ may be used uninitialized [-Werror=maybe-uninitialized]
>   284 |             int *expand = table_p.table_pointer_expand[i];
>       |                  ^~~~~~
> /home/ykaul/github/wireshark/epan/dissectors/packet-asterix.c:278:18: note: ‘table_p.table_pointer_expand’ was declared here
>   278 |     table_params table_p;
>       |                  ^~~~~~~
> /home/ykaul/github/wireshark/epan/dissectors/packet-asterix.c:278:18: error: ‘table_p.table_size’ may be used uninitialized [-Werror=maybe-uninitialized]
>

_______________________________________________
Wireshark-dev mailing list -- wireshark-dev@xxxxxxxxxxxxx
To unsubscribe send an email to wireshark-dev-leave@xxxxxxxxxxxxx