Wireshark-dev: [Wireshark-dev] Re: Windows build failure

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: John Thacker <johnthacker@xxxxxxxxx>
Date: Tue, 20 May 2025 11:38:18 -0400
The Qt deprecation warning is because of QCustomPlot which is 3rd party code- we have disabled failing compilation on those warnings while waiting for a fix there, but it's taken a while ( https://www.qcustomplot.com/index.php/support/forum/2794
)
so maybe we'll have to write our own patch. It started warning with Qt 6.8.0

The warning level change is also due to 3rd party code, Lemon, where we lower the warning level on MSVC when compiling it.

John

On Tue, May 20, 2025, 11:14 AM Maynard, Chris via Wireshark-dev <wireshark-dev@xxxxxxxxxxxxx> wrote:

FYI: I upgraded CMake to version 4.0.2 and was able to successfully build again.  Perhaps this wasn’t necessary for me to do, but since it’s working now, I’m not going to complain.  There are 2 new additional warnings produced though:

 

Build succeeded.

 

       "C:\Wireshark\builds\x64\master\Wireshark.sln" (default target) (1) ->

       "C:\Wireshark\builds\x64\master\wireshark.vcxproj.metaproj" (default target

       ) (2) ->

       "C:\Wireshark\builds\x64\master\epan\epan.vcxproj.metaproj" (default target

       ) (7) ->

       "C:\Wireshark\builds\x64\master\epan\dfilter\dfilter.vcxproj.metaproj" (def

       ault target) (10) ->

       "C:\Wireshark\builds\x64\master\tools\lemon\lemon.vcxproj.metaproj" (defaul

       t target) (11) ->

       "C:\Wireshark\builds\x64\master\tools\lemon\lemon.vcxproj" (default target)

        (104) ->

       (ClCompile target) ->

         cl : command line  warning D9025: overriding '/W3' with '/w' [C:\Wireshar

       k\builds\x64\master\tools\lemon\lemon.vcxproj]

 

 

       "C:\Wireshark\builds\x64\master\Wireshark.sln" (default target) (1) ->

       "C:\Wireshark\builds\x64\master\wireshark.vcxproj.metaproj" (default target

       ) (2) ->

       "C:\Wireshark\builds\x64\master\ui\qt\qtui.vcxproj.metaproj" (default targe

       t) (21) ->

       "C:\Wireshark\builds\x64\master\ui\qt\qtui.vcxproj" (default target) (117)

       ->

         C:\Wireshark\src\master\ui\qt\widgets\qcustomplot.cpp(6722,48): warning C

       4996: 'QDateTime::toTimeSpec': Use toTimeZone instead [C:\Wireshark\builds\

       x64\master\ui\qt\qtui.vcxproj]

         C:\Wireshark\src\master\ui\qt\widgets\qcustomplot.cpp(6827,15): warning C

       4996: 'QDate::startOfDay': Pass QTimeZone instead [C:\Wireshark\builds\x64\

       master\ui\qt\qtui.vcxproj]

 

    3 Warning(s)

    0 Error(s)

 

 

From: Maynard, Chris via Wireshark-dev <wireshark-dev@xxxxxxxxxxxxx>
Sent: Monday, May 19, 2025 2:23 PM
To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
Cc: Maynard, Chris <Christopher.Maynard@xxxxxxx>
Subject: [Wireshark-dev] Re: Windows build failure

 

Indeed, this particular problem is resolved.  Unfortunately, I’m now experiencing another failure, possibly due to a cmake version difference?  From https://gitlab.com/wireshark/wireshark/-/jobs/10080092481, I can see CMake 3.30.5 is in use, but my environment is using version 3.31.6.

 

 

Build FAILED.

 

       "C:\Wireshark\builds\x64\master\Wireshark.sln" (default target) (1) ->

       "C:\Wireshark\builds\x64\master\wireshark.vcxproj.metaproj" (default target

       ) (2) ->

       "C:\Wireshark\builds\x64\master\epan\epan.vcxproj.metaproj" (default target

       ) (7) ->

       "C:\Wireshark\builds\x64\master\epan\dfilter\dfilter.vcxproj.metaproj" (def

       ault target) (10) ->

       "C:\Wireshark\builds\x64\master\tools\lemon\lemon.vcxproj.metaproj" (defaul

       t target) (11) ->

       "C:\Wireshark\builds\x64\master\tools\lemon\lemon.vcxproj" (default target)

        (106) ->

       (ClCompile target) ->

         cl : command line  warning D9025: overriding '/W3' with '/w' [C:\Wireshar

       k\builds\x64\master\tools\lemon\lemon.vcxproj]

 

 

       "C:\Wireshark\builds\x64\master\Wireshark.sln" (default target) (1) ->

       "C:\Wireshark\builds\x64\master\wireshark.vcxproj.metaproj" (default target

       ) (2) ->

       "C:\Wireshark\builds\x64\master\ui\qt\qtui.vcxproj.metaproj" (default targe

       t) (21) ->

       "C:\Wireshark\builds\x64\master\ui\qt\qtui_autogen.vcxproj.metaproj" (defau

       lt target) (22) ->

       "C:\Wireshark\builds\x64\master\ui\qt\qtui_autogen.vcxproj" (default target

       ) (99) ->

       (CustomBuild target) ->

         C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft

       \VC\v170\Microsoft.CppCommon.targets(254,5): error MSB8066: Custom build fo

       r 'C:\Wireshark\builds\x64\master\CMakeFiles\8d4498c73f6c4c25c95ff94fdf915f

       56\wireshark_ca.qm.rule;C:\Wireshark\builds\x64\master\CMakeFiles\8d4498c73

       f6c4c25c95ff94fdf915f56\wireshark_de.qm.rule;C:\Wireshark\builds\x64\master

       \CMakeFiles\8d4498c73f6c4c25c95ff94fdf915f56\wireshark_en.qm.rule;C:\Wiresh

       ark\builds\x64\master\CMakeFiles\8d4498c73f6c4c25c95ff94fdf915f56\wireshark

       _es.qm.rule;C:\Wireshark\builds\x64\master\CMakeFiles\8d4498c73f6c4c25c95ff

       94fdf915f56\wireshark_fr.qm.rule;C:\Wireshark\builds\x64\master\CMakeFiles\

       8d4498c73f6c4c25c95ff94fdf915f56\wireshark_ga_IE.qm.rule;C:\Wireshark\build

       s\x64\master\CMakeFiles\8d4498c73f6c4c25c95ff94fdf915f56\wireshark_hu.qm.ru

       le;C:\Wireshark\builds\x64\master\CMakeFiles\8d4498c73f6c4c25c95ff94fdf915f

       56\wireshark_it.qm.rule;C:\Wireshark\builds\x64\master\CMakeFiles\8d4498c73

       f6c4c25c95ff94fdf915f56\wireshark_ja_JP.qm.rule;C:\Wireshark\builds\x64\mas

       ter\CMakeFiles\8d4498c73f6c4c25c95ff94fdf915f56\wireshark_ko.qm.rule;C:\Wir

       eshark\builds\x64\master\CMakeFiles\8d4498c73f6c4c25c95ff94fdf915f56\wiresh

       ark_pl.qm.rule;C:\Wireshark\builds\x64\master\CMakeFiles\8d4498c73f6c4c25c9

       5ff94fdf915f56\wireshark_pt_BR.qm.rule;C:\Wireshark\builds\x64\master\CMake

       Files\8d4498c73f6c4c25c95ff94fdf915f56\wireshark_ru.qm.rule;C:\Wireshark\bu

       ilds\x64\master\CMakeFiles\8d4498c73f6c4c25c95ff94fdf915f56\wireshark_sv.qm

       .rule;C:\Wireshark\builds\x64\master\CMakeFiles\8d4498c73f6c4c25c95ff94fdf9

       15f56\wireshark_tr_TR.qm.rule;C:\Wireshark\builds\x64\master\CMakeFiles\8d4

       498c73f6c4c25c95ff94fdf915f56\wireshark_uk.qm.rule;C:\Wireshark\builds\x64\

       master\CMakeFiles\8d4498c73f6c4c25c95ff94fdf915f56\wireshark_zh_CN.qm.rule;

       C:\Wireshark\builds\x64\master\CMakeFiles\a98377d28d711909e84a92bab36586c0\

       qtui_autogen.rule;C:\Wireshark\src\master\ui\qt\CMakeLists.txt' exited with

        code -1073741819. [C:\Wireshark\builds\x64\master\ui\qt\qtui_autogen.vcxpr

       oj]

 

    1 Warning(s)

    1 Error(s)

 

- Chris

 

 

From: John Thacker <johnthacker@xxxxxxxxx>
Sent: Friday, May 16, 2025 7:57 AM
To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
Subject: [Wireshark-dev] Re: Windows build failure

 

I updated to the latest version of Visual Studio and saw the same warnings. They should be fixed now.

 

On Thu, May 15, 2025, 12:34 PM John Thacker <johnthacker@xxxxxxxxx> wrote:

The following link does suggest that MSVC 17.14.0 had some changes around warning if enums weren't the same type:

 

https://developercommunity.visualstudio.com/t/warning-C5287:-operands-are-different-e/10877942

 

Though I think in our case we ought to be able to resolve it by fixing the casts or using values from the correct enums.

 

John

 

 

On Thu, May 15, 2025, 12:26 PM John Thacker <johnthacker@xxxxxxxxx> wrote:

I can see why all of those are warnings, as there's some incorrect casts or entries from the wrong enum (with the correct value, though) used. I suppose the latest MSVC is warning but the earlier versions don't.

 

John

 

On Thu, May 15, 2025, 10:05 AM Maynard, Chris via Wireshark-dev <wireshark-dev@xxxxxxxxxxxxx> wrote:

I’m using Visual Studio 17.14.0 (MSVC 19.44.35207.1) and seeing warnings with master, which are causing a build failure.  It looks like https://gitlab.com/wireshark/wireshark/-/jobs/10045948387 is working fine, but it’s using MSVC 19.41.34123.0, so maybe that’s why it works there but not for me?  Anyone else seeing this?

 

       "C:\Wireshark\builds\x64\master\Wireshark.sln" (default target) (1) ->

       "C:\Wireshark\builds\x64\master\wireshark.vcxproj.metaproj" (default target

       ) (2) ->

       "C:\Wireshark\builds\x64\master\epan\epan.vcxproj.metaproj" (default target

       ) (7) ->

       "C:\Wireshark\builds\x64\master\epan\dissectors\dissectors.vcxproj.metaproj

       " (default target) (13) ->

       "C:\Wireshark\builds\x64\master\epan\dissectors\dissectors.vcxproj" (defaul

       t target) (111) ->

       (ClCompile target) ->

         C:\Wireshark\src\master\epan\dissectors\packet-netlink-generic.c(251,7):

       warning C5286: implicit conversion from enum type '<unnamed-enum-WS_CTRL_CM

       D_UNSPEC>' to enum type 'ws_genl_ctrl_attr'; use an explicit cast to silenc

       e this warning [C:\Wireshark\builds\x64\master\epan\dissectors\dissectors.v

       cxproj]

         C:\Wireshark\src\master\epan\dissectors\packet-netlink-net_dm.c(232,7): w

       arning C5286: implicit conversion from enum type 'ws_net_dm_attrs_stats' to

        enum type 'ws_net_dm_attrs_port'; use an explicit cast to silence this war

       ning [C:\Wireshark\builds\x64\master\epan\dissectors\dissectors.vcxproj]

         C:\Wireshark\src\master\epan\dissectors\packet-netlink-netfilter.c(580,8)

       : warning C5286: implicit conversion from enum type 'ws_ctattr_l4proto' to

       enum type 'ws_ctattr_ip'; use an explicit cast to silence this warning [C:\

       Wireshark\builds\x64\master\epan\dissectors\dissectors.vcxproj]

         C:\Wireshark\src\master\epan\dissectors\packet-netlink-netfilter.c(584,8)

       : warning C5286: implicit conversion from enum type 'ws_ctattr_l4proto' to

       enum type 'ws_ctattr_ip'; use an explicit cast to silence this warning [C:\

       Wireshark\builds\x64\master\epan\dissectors\dissectors.vcxproj]

         C:\Wireshark\src\master\epan\dissectors\packet-netlink-netfilter.c(588,8)

       : warning C5286: implicit conversion from enum type 'ws_ctattr_l4proto' to

       enum type 'ws_ctattr_ip'; use an explicit cast to silence this warning [C:\

       Wireshark\builds\x64\master\epan\dissectors\dissectors.vcxproj]

         C:\Wireshark\src\master\epan\dissectors\packet-tcpcl.c(1306,45): warning

       C5287: operands are different enum types 'Tcpclv3MessageType' and 'Tcpclv3D

       ataSegmentFlag'; use an explicit cast to silence this warning [C:\Wireshark

       \builds\x64\master\epan\dissectors\dissectors.vcxproj]

         C:\Wireshark\src\master\epan\dissectors\packet-netlink-netfilter.c(854,8)

       : warning C5286: implicit conversion from enum type 'ws_ctattr_expect_nat'

       to enum type 'ws_ctattr_expect'; use an explicit cast to silence this warni

       ng [C:\Wireshark\builds\x64\master\epan\dissectors\dissectors.vcxproj]

         C:\Wireshark\src\master\epan\dissectors\packet-netlink-netfilter.c(858,8)

       : warning C5286: implicit conversion from enum type 'ws_ctattr_expect_nat'

       to enum type 'ws_ctattr_expect'; use an explicit cast to silence this warni

       ng [C:\Wireshark\builds\x64\master\epan\dissectors\dissectors.vcxproj]

 

- Chris

 

 

 

 

 

 

CONFIDENTIALITY NOTICE: This message is the property of International Game Technology PLC and/or its subsidiaries and may contain proprietary, confidential or trade secret information. This message is intended solely for the use of the addressee. If you are not the intended recipient and have received this message in error, please delete this message from your system. Any unauthorized reading, distribution, copying, or other use of this message or its attachments is strictly prohibited.
_______________________________________________
Wireshark-dev mailing list -- wireshark-dev@xxxxxxxxxxxxx
To unsubscribe send an email to wireshark-dev-leave@xxxxxxxxxxxxx