MR 17536 should be a reasonably conservative fix such that O_PATH will still be used if such a macro exists, but O_RDONLY will instead be used on platforms lacking O_PATH.
https://gitlab.com/wireshark/wireshark/-/merge_requests/17536
I have tested that fix on Debian Linux 12 and on macOS Sonoma 14.7 w/ Xcode 16.0, the latter of which lacks DBus support so that code path won't even be compiled.
It's going through the CI pipeline now, which should give us a bit more coverage... It'll need to be manually tested on NetBSD though.
Feedback is welcome, as always.
Thanks, and sorry for breaking this in the first place...
--
Darius
On Sat, 5 Oct 2024, at 8:02 PM, Jaap Keuter wrote:
> Hi all,
>
> It would be nice to clean up before 4.4.1 rolls of the presses. I can
> think of one issue we need to decide on.
> https://gitlab.com/wireshark/wireshark/-/issues/20031
> The proper answer doesn’t seem obvious, but apparently a change is
> required. Which change shall we make?
> Without testing infra we can’t really tell what we’ll break, but we can
> make some assumptions, can we?
>
> Thanks,
> Jaap
>
> _______________________________________________
> Wireshark-dev mailing list -- wireshark-dev@xxxxxxxxxxxxx
> To unsubscribe send an email to wireshark-dev-leave@xxxxxxxxxxxxx