Wireshark-dev: [Wireshark-dev] Re: [PATCH 0/8] SMB: Improve dissector

From: Pascal Quantin <pascal@xxxxxxxxxxxxx>
Date: Sat, 14 Sep 2024 18:21:17 +0200 (GMT+02:00)
Hi Pali,

Thanks for your submissions but sending them to the mailing list is not the workflow we use since quite a long time. Please see https://gitlab.com/wireshark/wireshark/-/wikis/Development/SubmittingPatches on how to properly submit your changes and get them reviewed.

Best regards,
Pascal.

14 sept. 2024 18:15:12 Pali Rohár via Wireshark-dev <wireshark-dev@xxxxxxxxxxxxx>:

> This patch series contains fixes and improvements for Wireshark SMB dissector.
> 
> Pali Rohár (8):
>   SMB: Update description of SMB access mask bits
>   SMB: Remove NT/SMB/Windows access mask constant 0x00800000
>   SMB: Dissect NT/SMB/Windows access mask constant 0x01000000
>     (SYSTEM_SECURITY_ACCESS)
>   SMB: Fix description of NT/SMB/Windows Server Security control bit in
>     Security Descriptor
>   SMB: Fix description of NT/SMB/Windows Specific access mask constants
>   SMB: Move non-generic NT/SMB/Windows access masks out of the generic
>     subtree
>   SMB: Dissect all NT/SMB/Windows access mask bits
>   SMB: Fix decoding SMB2 SESSION SETUP REQUEST field NTLM Calling
>     workstation domain and name in UNICODE format
> 
> epan/dissectors/packet-ntlmssp.c        |  8 ++-
> epan/dissectors/packet-smb.c            | 16 ++---
> epan/dissectors/packet-windows-common.c | 87 +++++++++++++++++++------
> epan/dissectors/packet-windows-common.h |  1 -
> 4 files changed, 82 insertions(+), 30 deletions(-)
> 
> -- 
> 2.20.1
> 
> _______________________________________________
> Wireshark-dev mailing list -- wireshark-dev@xxxxxxxxxxxxx
> To unsubscribe send an email to wireshark-dev-leave@xxxxxxxxxxxxx