Wireshark-dev: [Wireshark-dev] [PATCH 2/8] SMB: Remove NT/SMB/Windows access mask constant 0x00

From: Pali Rohár <pali@xxxxxxxxxx>
Date: Fri, 13 Sep 2024 22:58:28 +0200
Access mask constant 0x00800000 is not used by NT, SMB or Windows systems
for anything. It does not gain access to SACLs.
---
 epan/dissectors/packet-windows-common.c | 7 -------
 epan/dissectors/packet-windows-common.h | 1 -
 2 files changed, 8 deletions(-)

diff --git a/epan/dissectors/packet-windows-common.c b/epan/dissectors/packet-windows-common.c
index d198a98467d2..5709c6e7c31b 100644
--- a/epan/dissectors/packet-windows-common.c
+++ b/epan/dissectors/packet-windows-common.c
@@ -2198,7 +2198,6 @@ static int ett_nt_access_mask_generic;
 static int ett_nt_access_mask_standard;
 static int ett_nt_access_mask_specific;
 
-static int hf_access_sacl;
 static int hf_access_maximum_allowed;
 static int hf_access_generic_read;
 static int hf_access_generic_write;
@@ -2286,7 +2285,6 @@ dissect_nt_access_mask(tvbuff_t *tvb, int offset, packet_info *pinfo,
 		&hf_access_generic_execute,
 		&hf_access_generic_all,
 		&hf_access_maximum_allowed,
-		&hf_access_sacl,
 		NULL
 	};
 
@@ -3363,11 +3361,6 @@ proto_do_register_windows_common(int proto_smb)
 		    FT_BOOLEAN, 32, TFS(&tfs_set_notset),
 		    MAXIMUM_ALLOWED_ACCESS, NULL, HFILL }},
 
-		{ &hf_access_sacl,
-		  { "Access SACL", "nt.access_mask.access_sacl",
-		    FT_BOOLEAN, 32, TFS(&tfs_set_notset),
-		    ACCESS_SACL_ACCESS, NULL, HFILL }},
-
 		{ &hf_access_standard_read_control,
 		  { "Read control", "nt.access_mask.read_control",
 		    FT_BOOLEAN, 32, TFS(&tfs_set_notset),
diff --git a/epan/dissectors/packet-windows-common.h b/epan/dissectors/packet-windows-common.h
index 85da6b842519..aeac78fe161e 100644
--- a/epan/dissectors/packet-windows-common.h
+++ b/epan/dissectors/packet-windows-common.h
@@ -5748,7 +5748,6 @@ int dissect_nt_sid_ret_item(tvbuff_t *tvb, int offset, proto_tree *parent_tree,
 
 /* Misc/reserved */
 
-#define ACCESS_SACL_ACCESS     0x00800000
 #define SYSTEM_SECURITY_ACCESS 0x01000000
 #define MAXIMUM_ALLOWED_ACCESS 0x02000000
 
-- 
2.20.1