[Anders Broman <a.broman58@xxxxxxxxx>]

Den tis 6 aug. 2024 kl 20:50 skrev Guy Harris <gharris@xxxxxxxxx>:

On Aug 6, 2024, at 10:24 AM, Anders Broman <a.broman58@xxxxxxxxx> wrote:

> Could someone regenerate the pidl dissectors to fix the build?

On macOS (this should work on any UN*X from the command line), I went to the build directory and did

        #
        # Remove stamp files to force a rebuild.
        #
        find epan/dissectors/asn1 -name '*-stamp' -print | xargs rm

        #
        # Rebuild the ASN.1 dissectors.
        #
        ninja asn1 2>&1 | tee asn1.out

The rebuilt dissectors were the same as the ones in the repository.

> I didn't Manage to generate all of them(?) on windows.

I tried a build on my Windows VM, doing

        msbuild epan\dissectors\asn1\asn1.vcxproj

in the build directory, and got:

        MSBuild version 17.10.4+10fbfbf2e for .NET Framework
        Build started 8/6/2024 11:27:32 AM.

        Project "C:\Development\wsbuild64\epan\dissectors\asn1\asn1.vcxproj" on node 1 (default targets).
        Project "C:\Development\wsbuild64\epan\dissectors\asn1\asn1.vcxproj" (1) is building "C:\Development\wsbuild64\ZERO_CHECK.vcxproj" (2) on node 1 (default targets).
        PrepareForBuild:
          Creating directory "x64\Debug\ZERO_CHECK\".
          Structured output is enabled. The formatting of compiler diagnostics will reflect the error hierarchy. See https://aka.ms/cpp/structured-output for more details.
          Creating directory "x64\Debug\ZERO_CHECK\ZERO_CHECK.tlog\".
        InitializeBuildStatus:
          Creating "x64\Debug\ZERO_CHECK\ZERO_CHECK.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
          Touching "x64\Debug\ZERO_CHECK\ZERO_CHECK.tlog\unsuccessfulbuild".
        PreBuildEvent:
          Checking File Globs
          setlocal
          "C:\Program Files\Microsoft Visual Studio\2022\Community\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe" -P C:/Development/wsbuild64/CMakeFiles/VerifyGlobs.cmake
          if %errorlevel% neq 0 goto :cmEnd
          :cmEnd
          endlocal & call :cmErrorLevel %errorlevel% & goto :cmDone
          :cmErrorLevel
          exit /b %1
          :cmDone
          if %errorlevel% neq 0 goto :VCEnd
          :VCEnd
        CustomBuild:
          1>Checking Build System
        FinalizeBuildStatus:
          Deleting file "x64\Debug\ZERO_CHECK\ZERO_CHECK.tlog\unsuccessfulbuild".
          Touching "x64\Debug\ZERO_CHECK\ZERO_CHECK.tlog\ZERO_CHECK.lastbuildstate".
        Done Building Project "C:\Development\wsbuild64\ZERO_CHECK.vcxproj" (default targets).
        Project "C:\Development\wsbuild64\epan\dissectors\asn1\asn1.vcxproj" (1) is building "C:\Development\wsbuild64\epan\dissectors\asn1\HI2Operations\generate_dissector-HI2Operations.vcxproj" (3) on node 1 (default targets).
        PrepareForBuild:
          Creating directory "x64\Debug\generate_dissector-HI2Operations\".
          Structured output is enabled. The formatting of compiler diagnostics will reflect the error hierarchy. See https://aka.ms/cpp/structured-output for more details.
          Creating directory "x64\Debug\generate_dissector-HI2Operations\generate.925D9885.tlog\".
        InitializeBuildStatus:
          Creating "x64\Debug\generate_dissector-HI2Operations\generate.925D9885.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
          Touching "x64\Debug\generate_dissector-HI2Operations\generate.925D9885.tlog\unsuccessfulbuild".
        CustomBuild:
          "The build of 'C:\Development\wsbuild64\CMakeFiles\595c1b2866ce0f8db90673d7daa6e93f\generate_dissector-HI2Operations.rule' depends on 'C:\DEVELOPMENT\WSBUILD64\EPAN\DISSECTORS\ASN1\HI2OPERATIONS\PACKET-HI2OPERATIONS-STAMP' which is produced by the build of 'C:\Development\wsbuild64\CMakeFiles\b90769b44626848a76340bbf62177211\packet-HI2Operations-stamp.rule'. The items cannot be built in parallel."
          Generating packet-HI2Operations-stamp
          Building Custom Rule C:/Development/wireshark/epan/dissectors/asn1/HI2Operations/CMakeLists.txt
        FinalizeBuildStatus:
          Deleting file "x64\Debug\generate_dissector-HI2Operations\generate.925D9885.tlog\unsuccessfulbuild".
          Touching "x64\Debug\generate_dissector-HI2Operations\generate.925D9885.tlog\generate_dissector-HI2Operations.lastbuildstate".
        Done Building Project "C:\Development\wsbuild64\epan\dissectors\asn1\HI2Operations\generate_dissector-HI2Operations.vcxproj" (default targets).
        Project "C:\Development\wsbuild64\epan\dissectors\asn1\asn1.vcxproj" (1) is building "C:\Development\wsbuild64\epan\dissectors\asn1\acp133\generate_dissector-acp133.vcxproj" (4) on node 1 (default targets).
        Project "C:\Development\wsbuild64\epan\dissectors\asn1\acp133\generate_dissector-acp133.vcxproj" (4) is building "C:\Development\wsbuild64\epan\dissectors\asn1\p1\generate-p1-exp.cnf.vcxproj" (5) on node 1 (default targets).
        Project "C:\Development\wsbuild64\epan\dissectors\asn1\p1\generate-p1-exp.cnf.vcxproj" (5) is building "C:\Development\wsbuild64\epan\dissectors\asn1\x509af\generate-x509af-exp.cnf.vcxproj" (6) on node 1 (default targets).

                ...

        FinalizeBuildStatus:
          Deleting file "x64\Debug\asn1\asn1.tlog\unsuccessfulbuild".
          Touching "x64\Debug\asn1\asn1.tlog\asn1.lastbuildstate".
        Done Building Project "C:\Development\wsbuild64\epan\dissectors\asn1\asn1.vcxproj" (default targets).

        Build succeeded.
            0 Warning(s)
            0 Error(s)

        Time Elapsed 00:03:31.63

so it may be that it didn't get an *error*, but didn't do any building, either, for some reason.

That did the trick - thanks!

(C:\development\build\epan\dissectors\pidl)

Best regards

Anders 

_______________________________________________
Wireshark-dev mailing list -- wireshark-dev@xxxxxxxxxxxxx
To unsubscribe send an email to wireshark-dev-leave@xxxxxxxxxxxxx