Wireshark-dev: Re: [Wireshark-dev] Patch submission via e-mail/mailing list

From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Tue, 4 Jun 2024 18:55:51 +0200
Hi Bruno,

Indeed GitLab is currently the preferred way of working, so this is going in the right direction.

Good luck,
Jaap

On 4 Jun 2024, at 17:29, Bruno Mauricio <bruno.mauricio@xxxxxxxxxxxxxxxxxxx> wrote:

Alexis started pointing out some typos there, so I fixed them promptly.

Noone said anything but I guess it's better to finish up via gitlab.

Thank you very much for your support guys :)

Best regards,

Bruno Mauricio

On 6/4/24 4:14 PM, chuck c wrote:

Looks like there is work being done via the standard process?

On Tue, Jun 4, 2024 at 8:28 AM Bruno Mauricio via Wireshark-dev <wireshark-dev@xxxxxxxxxxxxx> wrote:
Hello again,

Just as I sent my previous e-mail, I got a confirmation from gitlab
about false flagging my account, which got reinstated and my Merge
Request reappeared.

Should we proceed via e-mails and I close the MR, or via the normal
procedure?

Apologies for the noise/spam,

Bruno Mauricio


On 6/4/24 2:22 PM, Bruno Mauricio via Wireshark-dev wrote:
> Thank you very much for your reply,
>
>
> I have attached the patch for Zigbee NCP dissector update in wireshark.
>
> I also attached a pcap which contains the added packets.
>
> Running wireshark (without the patch) shows a bunch of "Unknown Call
> ID" for packets which are now present with the patch.
>
> In case there is any issue please feel free to contact me directly, if
> you prefer not to spam this mailing list with those messages.
>
>
> Best regards,
>
> Bruno Mauricio
>
>
> On 6/4/24 2:03 PM, Jaap Keuter wrote:
>> Hi,
>>
>> First of all, sorry that GitLab gives you grief. Please do follow up
>> on the ticket, they usually seem to be open to address such issues
>> AFIACT.
>>
>> As for the patch, this used to be the channel through which these
>> were collected, before GitLab^WGerrit^WBugzilla.
>> So please go ahead and attach one here, and we’ll see what we can do.
>>
>> Thanks,
>> Jaap
>>
>>
>>> On 4 Jun 2024, at 12:48, Bruno Mauricio via Wireshark-dev
>>> <wireshark-dev@xxxxxxxxxxxxx> wrote:
>>>
>>> Hello,
>>>
>>>
>>> I created a Gitlab account just to send a patch for wireshark but it
>>> was banned a few minutes after I created the Merge Request.
>>>
>>> I tried creating a different account using gmail (and not this work
>>> e-mail, thought that might be the issue) but as soon as I input my
>>> phone number, it got banned as well. My number must have been
>>> flagged for some reason.
>>>
>>> I already opened a ticket but assume it will be some time until I
>>> get an answer back.
>>>
>>> In the meantime, what would be the better approach to submitting a
>>> patch without a gitlab account?
>>>
>>> Is this mailing list, or perhaps the Wireshark-commits mailing list
>>> appropriate for uploading a patch for review?
>>>
>>> Or should I sent it directly to a maintainer and if so to which
>>> e-mail address?
>>>
>>>
>>> Thank you for your attention.
>>>
>>> Best regards,
>>>
>>> Bruno Mauricio
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>               mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe