Wireshark-dev: Re: [Wireshark-dev] can't compile wireshark version 4.0

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <gharris@xxxxxxxxx>
Date: Thu, 20 Oct 2022 22:08:34 -0700
On Oct 20, 2022, at 5:15 PM, Guy Harris <gharris@xxxxxxxxx> wrote:

> Or just
> 	if (!g_ascii_isprint(ba[i])) {
> 
> as g_ascii_isprint() 1) is a macro, so no subroutine call overhead and 2) already correctly handles both signed and unsigned char.

Nope, do

	if (!g_ascii_isprint(ba[i]) && !g_ascii_iscntlr(ba[i])) {