Wireshark-dev: Re: [Wireshark-dev] How do I indicate that a commit or MR fixes an issue?

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: chuck c <bubbasnmp@xxxxxxxxx>
Date: Tue, 18 Oct 2022 13:11:15 -0500
Should be ok if it's !8558
https://docs.gitlab.com/ee/user/project/issues/managing_issues.html#closing-issues-automatically




On Tue, Oct 18, 2022 at 12:59 PM Richard Sharpe <realrichardsharpe@xxxxxxxxx> wrote:
On Tue, Oct 18, 2022 at 10:54 AM chuck c <bubbasnmp@xxxxxxxxx> wrote:
>
> https://wiki.wireshark.org/Development/SubmittingPatches#writing-a-good-commit-message
>
> As mentioned above, you can use "#" to reference issues.
> "Closes #1234" is special – it will close issue 1234 when the change is merged, while other references such as "see #4512" will simply link to the issue.

Thanks. Looks like I chose the wrong way :-(

> On Tue, Oct 18, 2022 at 12:46 PM Richard Sharpe <realrichardsharpe@xxxxxxxxx> wrote:
>>
>> Hi folks.
>>
>> What do I put in a commit message to indicate that it fixes an issue?
>>
>> --
>> Regards,
>> Richard Sharpe
>> (何以解憂？唯有杜康。--曹操)(传说杜康是酒的发明者)
>> ___________________________________________________________________________
>> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
>> Archives:    https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>              mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe



--
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)(传说杜康是酒的发明者)
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe