We should add wsutil/file_util.c to the exclusion list in validate-clang-check.sh. We might also want to add a way to manually skip the check, e.g. by checking for "[skip validate-clang-check]" in the commit message, similar to GitLab CI's "[skip ci]".
On 5/16/22 6:53 AM, Roland Knall wrote:
Hi
During the pipeline run I came across an error message for 3.6:
https://gitlab.com/wireshark/wireshark/-/jobs/2462018640 <https://gitlab.com/wireshark/wireshark/-/jobs/2462018640>
The file in question has a global check if it is being run on windows or otherwise forces a compile error. This hinders the check to run properly.
Should this be a valid test-case in this situation?
If yes, the check has to be performed plattform-independant or the file has to be modified. We have a few of those cases for Mac as well
Cheers
Roland
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives: https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe