On Dec 14, 2021, at 5:49 AM, João Valverde <j@xxxxxx> wrote:
> On 14/12/21 13:39, Gisle Vanem wrote:
>> João Valverde wrote:
>>
>>> you can (and probably should) include "config.h", just like other Wireshark bundled plugins do.
>>
>> Why does this project not use '-FI./config.h'?
>
> The header works fine, the consideration is that external plugins can only use the public API, and that header is not part of it.
And should never be part of it - for *any* project that provides headers and libraries for other code to use.
One problem is that the configuration settings with which the project was built are *not* necessarily the configuration settings with which the other code is being built; it might, for example, be compiled with a different compiler - which should be permitted as long as the two compilers build code using the same compiler-level ABI (calling sequence, etc.).