Wireshark-dev: [Wireshark-dev] Byte view mouse hover behaviour

From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Sat, 11 Sep 2021 13:23:18 +0200 (CEST)
Hi all,

Often when working with captured data from some development setup I wonder around the packet bytes with the mouse pointer to try and follow where in the code under development certain parts of a packet contents is being created. What happens now is that the highlighting of the field where this particular bytes are from follows the mouse pointer. But I'm working the other way around, by first selecting a field in the packet details, then dive into the packet bytes, where I would like the selected field highlighting to remain, so I can navigate around while keeping my bearings in the packet.

A very simple solution is this:

diff --git a/ui/qt/byte_view_tab.cpp b/ui/qt/byte_view_tab.cpp
index efb2cb1add..70ee2a4c5e 100644
--- a/ui/qt/byte_view_tab.cpp
+++ b/ui/qt/byte_view_tab.cpp
@@ -112,7 +112,7 @@ void ByteViewTab::addTab(const char *name, tvbuff_t *tvb) {

connect(wsApp, SIGNAL(zoomMonospaceFont(QFont)), byte_view_text, SLOT(setMonospaceFont(QFont)));

- connect(byte_view_text, SIGNAL(byteHovered(int)), this, SLOT(byteViewTextHovered(int)));
+ //connect(byte_view_text, SIGNAL(byteHovered(int)), this, SLOT(byteViewTextHovered(int)));
connect(byte_view_text, SIGNAL(byteSelected(int)), this, SLOT(byteViewTextMarked(int)));
connect(byte_view_text, SIGNAL(byteViewSettingsChanged()), this, SIGNAL(byteViewSettingsChanged()));
connect(this, SIGNAL(byteViewSettingsChanged()), byte_view_text, SLOT(updateByteViewSettings()));


But I recon this will upset people. So putting it behind a preference would a the way to go. The the question becomes where to put that? Anyone a good idea?

Thanks,
Jaap