Wireshark-dev: [Wireshark-dev] prefs.h - missing WS_DLL_PUBLIC

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: chuck c <bubbasnmp@xxxxxxxxx>
Date: Sat, 10 Jul 2021 12:44:28 -0500
https://gitlab.com/wireshark/wireshark/-/commit/1ebdb2e521ca0cbd7aeebd1c89b8a5cf6a4cc322
Export libwireshark symbols using WS_DLL_PUBLIC define

(Fingers crossed gitlab link works): epan/prefs.h
https://gitlab.com/wireshark/wireshark/-/commit/1ebdb2e521ca0cbd7aeebd1c89b8a5cf6a4cc322?page=9#4e4eae41a63c5a6aaa6e253345515537bec0f3ad

- extern module_t *prefs_register_protocol_obsolete(int id);
+ module_t *prefs_register_protocol_obsolete(int id);

Adding WS_DLL_PUBLIC to the line above fixes a link issue for the ethercat plugin.

Were the other cases, where "extern" was removed without adding WS_DLL_PUBLIC back in, done by design or were they missed and should be corrected?