[Gerald Combs <gerald@xxxxxxxxxxxxx>]

As far as I can tell, Chocolatey doesn't support alternative package dependencies, so you get too choose between depending on a specific JRE (which might install an unwanted extra copy of java.exe) or none (which requires an extra installation step). The AsciidoctorJ package went with the latter. I've added a note about installing a JRE separately to the Developer's Guide in MR 3441.

On 6/22/21 8:17 AM, Martin Mathieson via Wireshark-dev wrote:
> Will try this later.  Will be interesting to see if I get an automated corporate email telling me to uninstall the Oracle one :)
>
> On Tue, Jun 22, 2021 at 3:59 PM Graham Bloice <graham.bloice@xxxxxxxxxxxxx <mailto:graham.bloice@xxxxxxxxxxxxx>> wrote:
>
>
>
>     On Tue, 22 Jun 2021 at 15:56, Martin Mathieson via Wireshark-dev <wireshark-dev@xxxxxxxxxxxxx <mailto:wireshark-dev@xxxxxxxxxxxxx>> wrote:
>
>         I manually installed Java "Windows Offline (64-bit)" from java.com <http://java.com> (rather than trying*choco install javaruntime*) and am now able to build NSIS packages.
>
>
>     Note the licencing of Java for Oracle versions.  This may or may not be an issue for you.  Much simpler to use an "open" alternative, e.g. adoptopenjdk or others.
>
>
>         On Tue, Jun 22, 2021 at 3:45 PM chuck c <bubbasnmp@xxxxxxxxx <mailto:bubbasnmp@xxxxxxxxx>> wrote:
>
>             Maybe here https://community.chocolatey.org/packages/asciidoctorj <https://community.chocolatey.org/packages/asciidoctorj> and https://gitlab.com/wireshark/wireshark-containers/-/blob/master/dev/windows/Dockerfile <https://gitlab.com/wireshark/wireshark-containers/-/blob/master/dev/windows/Dockerfile> ?
>
>             On Tue, Jun 22, 2021 at 9:36 AM Graham Bloice <graham.bloice@xxxxxxxxxxxxx <mailto:graham.bloice@xxxxxxxxxxxxx>> wrote:
>
>                 The infamous "someone" should update the WSDG to call out Java (64 bit) as a prerequisite for the docs.
>
>                 On Tue, 22 Jun 2021 at 15:27, chuck c <bubbasnmp@xxxxxxxxx <mailto:bubbasnmp@xxxxxxxxx>> wrote:
>
>                     https://ask.wireshark.org/question/22386/wireshark-35-nsis-build-error/ <https://ask.wireshark.org/question/22386/wireshark-35-nsis-build-error/>
>                     "First time around building my dev environment (win10 x64), the Java installer picked 32-bit packages.
>                     Similar messages to what you are seeing. Fixed by reinstalling 64-bit Java."
>
>                     On Tue, Jun 22, 2021 at 8:39 AM Graham Bloice <graham.bloice@xxxxxxxxxxxxx <mailto:graham.bloice@xxxxxxxxxxxxx>> wrote:
>
>
>
>                         On Tue, 22 Jun 2021 at 13:41, Martin Mathieson via Wireshark-dev <wireshark-dev@xxxxxxxxxxxxx <mailto:wireshark-dev@xxxxxxxxxxxxx>> wrote:
>
>                             Does the Java warning sound important? Is there something I should do to try to increase the java heap size?  This machine should have loads (c20GB)  of memory available..
>
>                             image.png
>
>
>                         Odd, Java isn't called out as an installable by the Developers Guide but obviously ascidoctorj requires it.  Looking at my VM I have an old version of Oracle Java 8 installed and absolutely no idea where it came from:
>
>                          > java -version
>                         java version "1.8.0_221"
>                         Java(TM) SE Runtime Environment (build 1.8.0_221-b11)
>                         Java HotSpot(TM) 64-Bit Server VM (build 25.221-b11, mixed mode)
>
>                          > (Get-Command java.exe).Source
>                         C:\Program Files (x86)\Common Files\Oracle\Java\javapath\java.exe
>
>                         The invocation of asciidoctorj (if installed via chocolatey it will be <ChocoInstallDir>\lib\asciidoctorj\tools\asciidoctorj-x.x.x\bin\asciidoctorj.bat) sets JVM options for memory.
>
>                         I've never come across this before, and can't remember it being reported elsewhere.
>
>                             Best regards,
>                             Martin
>
>
>
>                         -- 
>                         Graham Bloice
>                         ___________________________________________________________________________
>                         Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx <mailto:wireshark-dev@xxxxxxxxxxxxx>>
>                         Archives: https://www.wireshark.org/lists/wireshark-dev <https://www.wireshark.org/lists/wireshark-dev>
>                         Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev <https://www.wireshark.org/mailman/options/wireshark-dev>
>                                       mailto:wireshark-dev-request@xxxxxxxxxxxxx <mailto:wireshark-dev-request@xxxxxxxxxxxxx>?subject=unsubscribe
>
>                     ___________________________________________________________________________
>                     Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx <mailto:wireshark-dev@xxxxxxxxxxxxx>>
>                     Archives: https://www.wireshark.org/lists/wireshark-dev <https://www.wireshark.org/lists/wireshark-dev>
>                     Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev <https://www.wireshark.org/mailman/options/wireshark-dev>
>                                   mailto:wireshark-dev-request@xxxxxxxxxxxxx <mailto:wireshark-dev-request@xxxxxxxxxxxxx>?subject=unsubscribe
>
>
>
>                 -- 
>                 Graham Bloice
>                 Software Developer
>                 Trihedral UK Limited
>                 ___________________________________________________________________________
>                 Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx <mailto:wireshark-dev@xxxxxxxxxxxxx>>
>                 Archives: https://www.wireshark.org/lists/wireshark-dev <https://www.wireshark.org/lists/wireshark-dev>
>                 Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev <https://www.wireshark.org/mailman/options/wireshark-dev>
>                               mailto:wireshark-dev-request@xxxxxxxxxxxxx <mailto:wireshark-dev-request@xxxxxxxxxxxxx>?subject=unsubscribe
>
>             ___________________________________________________________________________
>             Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx <mailto:wireshark-dev@xxxxxxxxxxxxx>>
>             Archives: https://www.wireshark.org/lists/wireshark-dev <https://www.wireshark.org/lists/wireshark-dev>
>             Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev <https://www.wireshark.org/mailman/options/wireshark-dev>
>                           mailto:wireshark-dev-request@xxxxxxxxxxxxx <mailto:wireshark-dev-request@xxxxxxxxxxxxx>?subject=unsubscribe
>
>         ___________________________________________________________________________
>         Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx <mailto:wireshark-dev@xxxxxxxxxxxxx>>
>         Archives: https://www.wireshark.org/lists/wireshark-dev <https://www.wireshark.org/lists/wireshark-dev>
>         Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev <https://www.wireshark.org/mailman/options/wireshark-dev>
>                       mailto:wireshark-dev-request@xxxxxxxxxxxxx <mailto:wireshark-dev-request@xxxxxxxxxxxxx>?subject=unsubscribe
>
>
>
>     -- 
>     Graham Bloice
>     Software Developer
>     Trihedral UK Limited
>     ___________________________________________________________________________
>     Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx <mailto:wireshark-dev@xxxxxxxxxxxxx>>
>     Archives: https://www.wireshark.org/lists/wireshark-dev <https://www.wireshark.org/lists/wireshark-dev>
>     Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev <https://www.wireshark.org/mailman/options/wireshark-dev>
>                   mailto:wireshark-dev-request@xxxxxxxxxxxxx <mailto:wireshark-dev-request@xxxxxxxxxxxxx>?subject=unsubscribe
>
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>               mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe