[Graham Bloice <graham.bloice@xxxxxxxxxxxxx>]

On Tue, 22 Jun 2021 at 15:45, chuck c <bubbasnmp@xxxxxxxxx> wrote:

Maybe here https://community.chocolatey.org/packages/asciidoctorj and https://gitlab.com/wireshark/wireshark-containers/-/blob/master/dev/windows/Dockerfile ?

From the asciidoctorj chocolatey package description:

You MUST install a Java runtime such as jre8, corretto8jre, or adoptopenjdk8jre yourself. This package doesn't presume to choose for you.

The docs should at least note the Java requirement, I think the adoptopenjdk8jre package from chocolatey should suffice.  It appears that by default this package will install a 64 bit Java if running on a 64 bit OS.

Clearly we don't enforce any checks in CMakeLists.txt that asciidoctorj is usable.

On Tue, Jun 22, 2021 at 9:36 AM Graham Bloice <graham.bloice@xxxxxxxxxxxxx> wrote:

The infamous "someone" should update the WSDG to call out Java (64 bit) as a prerequisite for the docs.

On Tue, 22 Jun 2021 at 15:27, chuck c <bubbasnmp@xxxxxxxxx> wrote:

https://ask.wireshark.org/question/22386/wireshark-35-nsis-build-error/

"First time around building my dev environment (win10 x64), the Java installer picked 32-bit packages.

Similar messages to what you are seeing. Fixed by reinstalling 64-bit Java."

On Tue, Jun 22, 2021 at 8:39 AM Graham Bloice <graham.bloice@xxxxxxxxxxxxx> wrote:

On Tue, 22 Jun 2021 at 13:41, Martin Mathieson via Wireshark-dev <wireshark-dev@xxxxxxxxxxxxx> wrote:

Does the Java warning sound important? Is there something I should do to try to increase the java heap size?  This machine should have loads (c20GB)  of memory available..

Odd, Java isn't called out as an installable by the Developers Guide but obviously ascidoctorj requires it.  Looking at my VM I have an old version of Oracle Java 8 installed and absolutely no idea where it came from:

> java -version
java version "1.8.0_221"
Java(TM) SE Runtime Environment (build 1.8.0_221-b11)
Java HotSpot(TM) 64-Bit Server VM (build 25.221-b11, mixed mode)

> (Get-Command java.exe).Source
C:\Program Files (x86)\Common Files\Oracle\Java\javapath\java.exe

The invocation of asciidoctorj (if installed via chocolatey it will be <ChocoInstallDir>\lib\asciidoctorj\tools\asciidoctorj-x.x.x\bin\asciidoctorj.bat) sets JVM options for memory.

I've never come across this before, and can't remember it being reported elsewhere.

Best regards,

Martin

--

Graham Bloice

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe

--

Graham Bloice

Software Developer

Trihedral UK Limited

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe

--

Graham Bloice

Software Developer

Trihedral UK Limited