["Bruni, Michelle" <Michelle.Bruni@xxxxxxxxxxx>]

Dario and Richard,

I want to thank you for getting back to me so quickly. Sorry for not responding sooner. I just realized this went into my junk folder. Thanks for the information. Richard to answer your question we would need to update existing packet_* files and we would be adding our own. 

Michelle

-----Original Message-----
From: Wireshark-dev <wireshark-dev-bounces@xxxxxxxxxxxxx> On Behalf Of wireshark-dev-request@xxxxxxxxxxxxx
Sent: Friday, December 6, 2019 4:31 PM
To: wireshark-dev@xxxxxxxxxxxxx
Subject: Wireshark-dev Digest, Vol 163, Issue 4

Send Wireshark-dev mailing list submissions to
	wireshark-dev@xxxxxxxxxxxxx

To subscribe or unsubscribe via the World Wide Web, visit
	https://www.wireshark.org/mailman/listinfo/wireshark-dev
or, via email, send a message with subject or body 'help' to
	wireshark-dev-request@xxxxxxxxxxxxx

You can reach the person managing the list at
	wireshark-dev-owner@xxxxxxxxxxxxx

When replying, please edit your Subject line so it is more specific than "Re: Contents of Wireshark-dev digest..."


Today's Topics:

   1. Adding a new packet to Wireshark (Bruni, Michelle)
   2. Re: Adding a new packet to Wireshark (Dario Lombardo)
   3. Re: Adding a new packet to Wireshark (Richard Sharpe)
   4. Re: Adding a new packet to Wireshark (Dario Lombardo)


----------------------------------------------------------------------

Message: 1
Date: Fri, 6 Dec 2019 20:48:40 +0000
From: "Bruni, Michelle" <Michelle.Bruni@xxxxxxxxxxx>
To: "wireshark-dev@xxxxxxxxxxxxx" <wireshark-dev@xxxxxxxxxxxxx>
Subject: [Wireshark-dev] Adding a new packet to Wireshark
Message-ID:
	<BN6PR10MB1539EDE207B6F76BDD30526F915F0@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
	
Content-Type: text/plain; charset="utf-8"

Hello,
I am Michelle and I work at Spirent Communications. We have been building Wireshark for many years because we had a proprietary signature field that we needed to decode and give to our customers. We are looking to open source our signature field and would like to put our packet dissectors into the Wireshark codebase. Before we get started on going through the process of committing and reviewing the changes into Wireshark I wanted to find out if this is something that is allowed and would get approved (after following the process of course).

Also we have some changes we have made to other packet dissectors that we will be pushing upstream and as we make new changes putting them back into the community.

Looking forward from hearing from you and working with the Wireshark community.

Michelle Bruni
Spirent Communications
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.wireshark.org/lists/wireshark-dev/attachments/20191206/43b6ed06/attachment.html>

------------------------------

Message: 2
Date: Fri, 6 Dec 2019 21:54:04 +0100
From: Dario Lombardo <lomato@xxxxxxxxx>
To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
Subject: Re: [Wireshark-dev] Adding a new packet to Wireshark
Message-ID:
	<CAOYJJfuUzqjP2tBURFTpotDbcr2DZPJ4NBB=rAy1FOj4-i_3hw@xxxxxxxxxxxxxx>
Content-Type: text/plain; charset="utf-8"

I can't see any blocker in what you're proposing. Feel free to push your proposals and follow the review process.
Thanks for the contribution.

On Fri, Dec 6, 2019 at 9:50 PM Bruni, Michelle <Michelle.Bruni@xxxxxxxxxxx>
wrote:

> Hello,
>
> I am Michelle and I work at Spirent Communications. We have been 
> building Wireshark for many years because we had a proprietary 
> signature field that we needed to decode and give to our customers. We 
> are looking to open source our signature field and would like to put 
> our packet dissectors into the Wireshark codebase. Before we get 
> started on going through the process of committing and reviewing the 
> changes into Wireshark I wanted to find out if this is something that 
> is allowed and would get approved (after following the process of course).
>
>
>
> Also we have some changes we have made to other packet dissectors that 
> we will be pushing upstream and as we make new changes putting them 
> back into the community.
>
>
>
> Looking forward from hearing from you and working with the Wireshark 
> community.
>
>
>
> Michelle Bruni
>
> Spirent Communications
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request@xxxxxxxxxxxxx
> ?subject=unsubscribe



-- 

Naima is online.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.wireshark.org/lists/wireshark-dev/attachments/20191206/8d98234b/attachment.html>

------------------------------

Message: 3
Date: Fri, 6 Dec 2019 12:55:59 -0800
From: Richard Sharpe <realrichardsharpe@xxxxxxxxx>
To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
Subject: Re: [Wireshark-dev] Adding a new packet to Wireshark
Message-ID:
	<CACyXjPxRNBXkYt707j8EFOn1tb82ZzY=eLAyNK_xsHSA0+nGaA@xxxxxxxxxxxxxx>
Content-Type: text/plain; charset="UTF-8"

On Fri, Dec 6, 2019 at 12:50 PM Bruni, Michelle <Michelle.Bruni@xxxxxxxxxxx> wrote:
>
> Hello,
>
> I am Michelle and I work at Spirent Communications. We have been building Wireshark for many years because we had a proprietary signature field that we needed to decode and give to our customers. We are looking to open source our signature field and would like to put our packet dissectors into the Wireshark codebase. Before we get started on going through the process of committing and reviewing the changes into Wireshark I wanted to find out if this is something that is allowed and would get approved (after following the process of course).

As Dario has already said, there should not be any problems. You will have to release the changes under the GPL, though.

As a matter of interest, is it a separate protocol or is it an addendum to an existing protocol?

> Also we have some changes we have made to other packet dissectors that we will be pushing upstream and as we make new changes putting them back into the community.

Anything that improves existing dissectors is welcome.

--
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)(传说杜康是酒的发明者)


------------------------------

Message: 4
Date: Fri, 6 Dec 2019 22:29:29 +0100
From: Dario Lombardo <lomato@xxxxxxxxx>
To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
Subject: Re: [Wireshark-dev] Adding a new packet to Wireshark
Message-ID:
	<CAOYJJfvKiLq_gnugcyQvC+R11FH2Y55UEKvQ0fur0KDfvu3h2Q@xxxxxxxxxxxxxx>
Content-Type: text/plain; charset="utf-8"

On Fri, Dec 6, 2019 at 9:58 PM Richard Sharpe <realrichardsharpe@xxxxxxxxx>
wrote:

>
> As Dario has already said, there should not be any problems. You will
> have to release the changes under the GPL, though.


Or any compatible licence. We have BSD licensed dissectors as well as GPL.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.wireshark.org/lists/wireshark-dev/attachments/20191206/2b15db52/attachment.html>

------------------------------

Subject: Digest Footer

_______________________________________________
Wireshark-dev mailing list
Wireshark-dev@xxxxxxxxxxxxx
https://www.wireshark.org/mailman/listinfo/wireshark-dev


------------------------------

End of Wireshark-dev Digest, Vol 163, Issue 4
*********************************************