Wireshark-dev: Re: [Wireshark-dev] Seeing these errors with packet-quic.c because I don't have

From: Richard Sharpe <realrichardsharpe@xxxxxxxxx>
Date: Thu, 1 Mar 2018 11:33:18 -0800
On Thu, Mar 1, 2018 at 11:24 AM, Alexis La Goutte
<alexis.lagoutte@xxxxxxxxx> wrote:
>
>>
>> Hi folks,
>>
>> Seeing this. Maybe need some _U_ on those parameters? Looks like the
>> ifdef is causing it because I don't have the latest libraries.
>>
>> packet-quic.c: In function 'dissect_quic_initial':
>> packet-quic.c:801:131: error: unused parameter 'pkn'
>> [-Werror=unused-parameter]
>>  dissect_quic_initial(tvbuff_t *tvb, packet_info *pinfo, proto_tree
>> *quic_tree, guint offset, quic_info_data_t *quic_info, guint32 pkn,
>> guint64 cid){
>>
>>                                                             ^
>> packet-quic.c:801:144: error: unused parameter 'cid'
>> [-Werror=unused-parameter]
>>  dissect_quic_initial(tvbuff_t *tvb, packet_info *pinfo, proto_tree
>> *quic_tree, guint offset, quic_info_data_t *quic_info, guint32 pkn,
>> guint64 cid){
>>
>>
>>   ^
>> packet-quic.c: In function 'dissect_quic_handshake':
>> packet-quic.c:848:114: error: unused parameter 'quic_info'
>> [-Werror=unused-parameter]
>>  dissect_quic_handshake(tvbuff_t *tvb, packet_info *pinfo, proto_tree
>> *quic_tree, guint offset, quic_info_data_t *quic_info, guint32 pkn){
>>
>>                                            ^
>> packet-quic.c:848:133: error: unused parameter 'pkn'
>> [-Werror=unused-parameter]
>>  dissect_quic_handshake(tvbuff_t *tvb, packet_info *pinfo, proto_tree
>> *quic_tree, guint offset, quic_info_data_t *quic_info, guint32 pkn){
>>
>>                                                               ^
>> packet-quic.c: In function 'dissect_quic_retry':
>> packet-quic.c:887:110: error: unused parameter 'quic_info'
>> [-Werror=unused-parameter]
>>  dissect_quic_retry(tvbuff_t *tvb, packet_info *pinfo, proto_tree
>> *quic_tree, guint offset, quic_info_data_t *quic_info, guint32 pkn){
>>
>>                                        ^
>> packet-quic.c:887:129: error: unused parameter 'pkn'
>> [-Werror=unused-parameter]
>>  dissect_quic_retry(tvbuff_t *tvb, packet_info *pinfo, proto_tree
>> *quic_tree, guint offset, quic_info_data_t *quic_info, guint32 pkn){
>>
>>                                                           ^
>> cc1: all warnings being treated as errors
>>
> Oups sorry !
> You really need to update your libgcrypt packages :)

Well, I can do that, but there are bound to be other people out there
who are on versions of Linux with old versions of libgcrypt as well.

-- 
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)