Wireshark-dev: Re: [Wireshark-dev] Wireshark 2.4.1 build errors (with Qt 4)
From: Michael Mann <mmann78@xxxxxxxxxxxx>
Date: Thu, 31 Aug 2017 11:04:22 -0400
Per the conversation that started with https://www.wireshark.org/lists/wireshark-dev/201707/msg00132.html, I would say that yes Qt 4 is still supported by Wireshark 2.4, but it looks like it won't be supported for Wireshark 2.6 release (in what is now current master branch). The problem is just that we don't have a Qt 4 build environment to catch build errors, so they go unnoticed until someone brings them up (like bug 13909 or what you're doing now).
Is this list of compile errors in addition to the ones you found on master? If you can submit a patch for the master-2.4 branch, that would certainly be appreciated (and accepted). Since the 2.4 branch is mostly bugfixes (the rare exception being horrific UI issues), I don't think additional compile errors should result going forward.
-----Original Message-----
From: Kilian, Jens <jens.kilian@xxxxxxxxxxxxx>
To: wireshark-dev <wireshark-dev@xxxxxxxxxxxxx>
Sent: Thu, Aug 31, 2017 10:36 am
Subject: [Wireshark-dev] Wireshark 2.4.1 build errors (with Qt 4)
Is Wireshark v2.4.1 supposed to support Qt 4 still? I get the following compile errors when trying to build it in RedHat EL 7.2:
main_window.cpp:786:46: required from here
/usr/include/QtCore/qmetatype.h:169:80: error: 'qt_metatype_id' is not a member of 'QMetaTypeId<QToolBar*>'
static inline int qt_metatype_id() { return QMetaTypeId<T>::qt_metatype_id(); }
^
main_window_slots.cpp:499:62: required from here
/usr/include/QtCore/qmetatype.h:169:80: error: 'qt_metatype_id' is not a member of 'QMetaTypeId<QToolBar*>'
static inline int qt_metatype_id() { return QMetaTypeId<T>::qt_metatype_id(); }
^
rtp_player_dialog.cpp:207:104: required from here
/usr/include/QtCore/qmetatype.h:169:80: error: 'qt_metatype_id' is not a member of 'QMetaTypeId<RtpAudioStream*>'
static inline int qt_metatype_id() { return QMetaTypeId<T>::qt_metatype_id(); }
^
rtp_player_dialog.cpp:277:95: required from here
/usr/include/QtCore/qmetatype.h:169:80: error: 'qt_metatype_id' is not a member of 'QMetaTypeId<QCPGraph*>'
wireless_timeline.cpp: In member function 'virtual void WirelessTimeline::mousePressEvent(QMouseEvent*)':
wireless_timeline.cpp:118:31: error: 'class QMouseEvent' has no member named 'localPos'
start_x = last_x = event->localPos().x();
^
wireless_timeline.cpp: In member function 'virtual void WirelessTimeline::mouseMoveEvent(QMouseEvent*)':
wireless_timeline.cpp:127:27: error: 'class QMouseEvent' has no member named 'localPos'
qreal offset = event->localPos().x() - last_x;
^
wireless_timeline.cpp:128:21: error: 'class QMouseEvent' has no member named 'localPos'
last_x = event->localPos().x();
^
wireless_timeline.cpp: In member function 'virtual void WirelessTimeline::mouseReleaseEvent(QMouseEvent*)':
wireless_timeline.cpp:144:27: error: 'class QMouseEvent' has no member named 'localPos'
qreal offset = event->localPos().x() - start_x;
^
wireless_timeline.cpp:151:36: error: 'class QMouseEvent' has no member named 'localPos'
guint num = find_packet(event->localPos().x());
^
wireless_timeline.cpp: In member function 'virtual void WirelessTimeline::paintEvent(QPaintEvent*)':
wireless_timeline.cpp:483:31: error: 'class QPaintDevice' has no member named 'devicePixelRatio'
float ratio = p.device()->devicePixelRatio();
^
wireshark_application.cpp: In constructor 'WiresharkApplication::WiresharkApplication(int&, char**)':
wireshark_application.cpp:850:24: error: 'QGuiApplication' has not been declared
QPalette gui_pal = QGuiApplication::palette();
^
Best regards,
Jens.
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
From: Kilian, Jens <jens.kilian@xxxxxxxxxxxxx>
To: wireshark-dev <wireshark-dev@xxxxxxxxxxxxx>
Sent: Thu, Aug 31, 2017 10:36 am
Subject: [Wireshark-dev] Wireshark 2.4.1 build errors (with Qt 4)
Is Wireshark v2.4.1 supposed to support Qt 4 still? I get the following compile errors when trying to build it in RedHat EL 7.2:
main_window.cpp:786:46: required from here
/usr/include/QtCore/qmetatype.h:169:80: error: 'qt_metatype_id' is not a member of 'QMetaTypeId<QToolBar*>'
static inline int qt_metatype_id() { return QMetaTypeId<T>::qt_metatype_id(); }
^
main_window_slots.cpp:499:62: required from here
/usr/include/QtCore/qmetatype.h:169:80: error: 'qt_metatype_id' is not a member of 'QMetaTypeId<QToolBar*>'
static inline int qt_metatype_id() { return QMetaTypeId<T>::qt_metatype_id(); }
^
rtp_player_dialog.cpp:207:104: required from here
/usr/include/QtCore/qmetatype.h:169:80: error: 'qt_metatype_id' is not a member of 'QMetaTypeId<RtpAudioStream*>'
static inline int qt_metatype_id() { return QMetaTypeId<T>::qt_metatype_id(); }
^
rtp_player_dialog.cpp:277:95: required from here
/usr/include/QtCore/qmetatype.h:169:80: error: 'qt_metatype_id' is not a member of 'QMetaTypeId<QCPGraph*>'
wireless_timeline.cpp: In member function 'virtual void WirelessTimeline::mousePressEvent(QMouseEvent*)':
wireless_timeline.cpp:118:31: error: 'class QMouseEvent' has no member named 'localPos'
start_x = last_x = event->localPos().x();
^
wireless_timeline.cpp: In member function 'virtual void WirelessTimeline::mouseMoveEvent(QMouseEvent*)':
wireless_timeline.cpp:127:27: error: 'class QMouseEvent' has no member named 'localPos'
qreal offset = event->localPos().x() - last_x;
^
wireless_timeline.cpp:128:21: error: 'class QMouseEvent' has no member named 'localPos'
last_x = event->localPos().x();
^
wireless_timeline.cpp: In member function 'virtual void WirelessTimeline::mouseReleaseEvent(QMouseEvent*)':
wireless_timeline.cpp:144:27: error: 'class QMouseEvent' has no member named 'localPos'
qreal offset = event->localPos().x() - start_x;
^
wireless_timeline.cpp:151:36: error: 'class QMouseEvent' has no member named 'localPos'
guint num = find_packet(event->localPos().x());
^
wireless_timeline.cpp: In member function 'virtual void WirelessTimeline::paintEvent(QPaintEvent*)':
wireless_timeline.cpp:483:31: error: 'class QPaintDevice' has no member named 'devicePixelRatio'
float ratio = p.device()->devicePixelRatio();
^
wireshark_application.cpp: In constructor 'WiresharkApplication::WiresharkApplication(int&, char**)':
wireshark_application.cpp:850:24: error: 'QGuiApplication' has not been declared
QPalette gui_pal = QGuiApplication::palette();
^
Best regards,
Jens.
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
- References:
- [Wireshark-dev] Wireshark 2.4.1 build errors (with Qt 4)
- From: Kilian, Jens
- [Wireshark-dev] Wireshark 2.4.1 build errors (with Qt 4)
- Prev by Date: Re: [Wireshark-dev] [RFC] Vendor-specific dissector extension for EtherNet/IP
- Next by Date: Re: [Wireshark-dev] Some updates to the Profinet plugin
- Previous by thread: [Wireshark-dev] Wireshark 2.4.1 build errors (with Qt 4)
- Next by thread: [Wireshark-dev] Some updates to the Profinet plugin
- Index(es):