Wireshark-dev: Re: [Wireshark-dev] Crash in epan/geoip_db.c

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Dario Lombardo <dario.lombardo.ml@xxxxxxxxx>
Date: Wed, 22 Feb 2017 15:50:12 +0100


On Tue, Feb 21, 2017 at 11:38 PM, João Valverde <joao.valverde@xxxxxxxxxxxxxxxxxx> wrote:

Fixes 850393b57bdd7011780f4cf897d4a2467f58a673. Please push to Gerrit. Bonus points for fixing the cast too.

I pushed a patch that replaces g_free with free. Now the problem is that checkAPI doesn't allow free! No way to make petri-dish pass. We can:

- merge without PD
- patch checkAPI to allow some forbidden calls in some files

Is it worth the latter or we should be fine with the former?