[Michael Mann <mmann78@xxxxxxxxxxxx>]

Note that a dissector for the NVME protocol was recently submitted (https://code.wireshark.org/review/19063).  I presume you've rebased to the latest commits on master to include that functionality (and maybe you're just adding support for more commands?)

 

 

-----Original Message-----
From: Nitzan Carmi <nitzanc@xxxxxxxxxxxx>
To: wireshark-dev <wireshark-dev@xxxxxxxxxxxxx>
Sent: Wed, Jan 25, 2017 2:13 pm
Subject: [Wireshark-dev] adding a new nvme dissector - pre-commit verifications

Hi,

 

At the past month I've been working on a new dissector for Wireshark, to parse NVME protocol (with a focus on the fabrics channel – Infiniband/RDMA).

So far, although not all commands are fully parsed yet (lots of commands to cover), the dissection flow is working correctly, thus I think I reached a milestone and

this is a good time to share the code and take comments before I continue.

But, since I am new to Wireshark, I would like to know (and save everybody's time) if there are things I need to check or pay attention to

(beyond the fuzz testing I already read about) Before I push my dissector to gerrit for review.

 

Thanks!

Nitzan.

 

___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives: https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe