Wireshark-dev: Re: [Wireshark-dev] Commit 3c1f71e: Build error "unused parameter 'ntlm_pass' [-

From: João Valverde <joao.valverde@xxxxxxxxxxxxxxxxxx>
Date: Tue, 19 Apr 2016 21:14:47 +0100


On 19-04-2016 21:02, Alexis La Goutte wrote:


On Tue, Apr 19, 2016 at 9:53 PM, Jo�o Valverde
<joao.valverde@xxxxxxxxxxxxxxxxxx
<mailto:joao.valverde@xxxxxxxxxxxxxxxxxx>> wrote:



    On 19-04-2016 20:38, Uli Heilmeier wrote:

        Hi list,

        since commit 3c1f71e my build system has failed in compiling the
        current master.

        The error is:

        ----
            CC       packet-dcerpc-rep_proc.lo
        packet-dcerpc-netlogon.c: In function 'get_keytab_as_list':
        packet-dcerpc-netlogon.c:6561:71: error: unused parameter
        'ntlm_pass' [-Werror=unused-parameter]
           static guint32 get_keytab_as_list(md4_pass **p_pass_list,
        const char* ntlm_pass)

                 ^
        ---

        When I revert one change compilation works again.

        --- a/epan/dissectors/packet-dcerpc-netlogon.c
        +++ b/epan/dissectors/packet-dcerpc-netlogon.c
        @@ -6558,7 +6558,7 @@ static void str_to_unicode(const char
        *nt_password, char *nt_password_unicode)
           }
           #endif

        -static guint32 get_keytab_as_list(md4_pass **p_pass_list, const
        char* ntlm_pass)
        +static guint32 get_keytab_as_list(md4_pass **p_pass_list, const
        char* ntlm_pass _U_ )
           {
           #ifdef HAVE_KERBEROS
               enc_key_t *ek;

        I've already did a 'git clean -d -X -i; ./autogen.sh;
        ./configure --with-kerberos --with-ssl --with-geoip' to have a
        clean repository.

        Any idea what's going wrong here?


    You don't have Kerberos enabled (HAVE_KERBEROS).

    That commit should be reverted.

or amend to add ifdef HAVE_KERBEROS to function argument...


Yeah... yuck. :-(


It is strange.. all buildbot have support of Kerberos ?!




        Thanks for any help!
        Uli
        ___________________________________________________________________________
        Sent via:    Wireshark-dev mailing list
        <wireshark-dev@xxxxxxxxxxxxx <mailto:wireshark-dev@xxxxxxxxxxxxx>>
        Archives: https://www.wireshark.org/lists/wireshark-dev
        Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
                       mailto:wireshark-dev-request@xxxxxxxxxxxxx
        <mailto:wireshark-dev-request@xxxxxxxxxxxxx>?subject=unsubscribe

    ___________________________________________________________________________
    Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx
    <mailto:wireshark-dev@xxxxxxxxxxxxx>>
    Archives: https://www.wireshark.org/lists/wireshark-dev
    Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
                 mailto:wireshark-dev-request@xxxxxxxxxxxxx
    <mailto:wireshark-dev-request@xxxxxxxxxxxxx>?subject=unsubscribe




___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
              mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe