Wireshark-dev: [Wireshark-dev] The ieee802.11 dissector is a steaming pile of ordure

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Richard Sharpe <realrichardsharpe@xxxxxxxxx>
Date: Wed, 9 Sep 2015 08:23:13 -0700
Take a look at epan/dissectors/packet-ieee80211.c!

Specifically, add_tagged_field.

That function is approximately 2,300 lines long and it consists of one
big switch statement with every arm containing open-coded statements
to add things to the proto tree.

Who does that?

-- 
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)