Wireshark-dev: Re: [Wireshark-dev] Wireshark messages I don't want to see

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Tue, 14 Jul 2015 21:13:49 +0200
On Tue, Jul 14, 2015 at 11:52:18AM -0700, Guy Harris wrote:
> Line 1558 of epan/crypt/airpdcap.c is
> 
> 	if (ctx->sa[ctx->first_free_index].used) { 
> 
> in AirPDcapStoreSa().  It was assuming that ctx->first_free_index would be within the bounds of the array, which isn't guaranteed (what if there *are* no free indices?); I've added a bounds check in 4f1b8d74338ca2a6ded8498e9d87cbc3294454c0.

This was on Linux (which has AIRPCAP disabled) and with only 2 entries total
(1x wpa, 1x wpa2)

Thanks!
   Jörg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.