On 5/9/15 4:34 AM, Graham Bloice wrote:
> On 9 May 2015 at 01:34, Gerald Combs <gerald@xxxxxxxxxxxxx
> <mailto:gerald@xxxxxxxxxxxxx>> wrote:
>
> The upgrade is complete. Logging in using your Google account, which was
> initially OK and then not OK is once again OK.
>
> You can now link your GitHub account as well.
>
> In either case if you have an existing account you should make sure your
> identities are properly linked by doing the following:
>
> - Log in using your existing OpenID provider
> - Go to https://code.wireshark.org/review/#/settings/web-identities
> - Click "Link Another Identity"
>
>
> Seems to work for me, without needing to relink my old Google identity.
>
> On the signin page the links for Google and Github were plain text
> rather than any icon, is that intentional?
Plain text is what Gerrit delivers by default and is the "cost of an
uglier login page" mentioned in the original email. Prior to the upgrade
I was replacing the contents of the login <div> with the Javascript
OpenID Selector[1]. Gerrit doesn't let you configure this directly so I
ended up using HTML injection. This is exactly as fun and reliable as it
sounds.
[1]https://code.google.com/p/openid-selector/