Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Stephen Fisher <sfisher@xxxxxxx>
Date: Mon, 15 Dec 2014 09:34:31 -0700
On Mon, Dec 15, 2014 at 08:23:47AM +0100, Michal Labedzki wrote:

> Personally I prefer ENC_NA for single-byte.

Me too.  How about changing proto_tree_add_item() so that the endian 
field is optional?

Single byte:

  proto_tree_add_item(tree, proto_test, tvb, 0, 1);

Multi-byte:

  proto_tree_add_item(tree, proto_test, tvb, 1, 2, ENC_BIG_ENDIAN);