On 12/01/14 13:29, Bálint Réczey wrote:
Hi Jeff,
2014-12-01 18:59 GMT+01:00 Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>:
On 11/29/14 05:44, Bálint Réczey wrote:
Hi Jeff,
2014-11-26 19:26 GMT+01:00 Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>:
On 11/26/14 13:01, Stephen Fisher wrote:
Is there any reason a user would have both GTK3 and GTK2 installed and
not want to use GTK3 for wireshark-gtk builds? We could simplify it to
be --with-gtk/--without-gtk and --with-qt/--without-qt and just use the
latest version of GTK on the system (3.x, if available, otherwise 2.x)
when requested. The default could remain to make a Qt and GTK build and
if the user didn't want GTK anymore, just pass --without-gtk to the
configure script.
I have both Gtk3 and Gtk2 installed but build with Gtk2. The Gtk3 UI
just
looks horrible to me (and, no, I'm not one who really cares about how
things
look but, well, I have a choice).
Could you please share a screenshot about what you find horrible in GTK3?
I'm using the Debian package which looks quite good to me and I
managed to get the OS X version to be nice as well:
(I generally build on Fedora though what I push to my users is for
RHEL/CentOS.)
I think what really did it for me was the Decode-As window:
https://www.wireshark.org/lists/wireshark-dev/201307/msg00198.html
I can (still) barely tell which tab I'm on.
Yes, the active and inactive tabs look almost the same, because there
is no theme installed for GTK+ and the default look was pretty ugly.
Adwaita became the built-in standard theme from GTK+3.14 thus the default look
should change to something similar to what I attached on every system.
That certainly looks usable (a big improvement from what's there now).
:-) I guess it's just a question of when I upgrade to a Fedora version
with the new Gtk3.
http://balintreczey.hu/blog/beautiful-wireshark-on-os-x-using-homebrew-and-gtk3quartz/
Looking at it more I think another thing that bothers me even on the home
page is that the (disabled - because in my build environment I don't have
capture privs) "start capture now" icon is green (but with a different color
background) rather than, as in the Gtk2 or Qt versions, well, not green at
all.
I can hardly fix that in GTK+3, it is the the icon shipped with Wireshark. :-)
Hmm it works well with Gtk2 though: I get a nice green icon when I can
capture and a nice gray icon (with the same shape) when I can't capture.
Do you mean for Gtk3 we need to ship 2 icons (one for enabled and one
for disabled) or are we disabling the icons the wrong way [in Gtk3]?