On 7/28/14 7:34 AM, Jeff Morriss wrote:
> On 07/27/14 13:34, Bálint Réczey wrote:
>> 2014-07-25 23:49 GMT+02:00 Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>:
>>> On 07/22/14 16:27, Wireshark announcements wrote:
>>>>
>>>> -----BEGIN PGP SIGNED MESSAGE-----
>>>> Hash: SHA1
>>>>
>>>> I'm proud to announce the release of Wireshark 1.12.0rc3. This is a
>>>> public release candidate for Wireshark 1.12.0.
>>>
>>>
>>> Hmm, the source tarball isn't in the expected directory (rc2 is still
>>> there):
>>>
>>> http://wiresharkdownloads.riverbed.com/wireshark/src/
>>>
>>> The "all-versions" directory does have it though.
Fixed.
>> It also did not contain quite some files. Could release tarballs
>> please be made using tools/git-export-release.sh? I had to use the
>> tagged git-snapshot for the Debian packages.
>
> It worked well for me. What files were missing?
>
> I think changing to git-snapshot would be too significant a change this
> late in the game: it means a lot of the auto-generated files (like
> ./configure) would not be delivered, right?
After comparing the tarballs generated by "make dist" and
"git-export-release.sh" I have to agree. Both have issues but the "dist"
tarball will build according to our documentation on Linux, Windows, and
OS X.
"make dist" is missing:
- Quite a bit under asn1. asn1/*/CMakeLists.txt, gnm, gprscdr,
and other assorted files.
- Several CMake modules
- Many files under debian
- Many docbook files
- Several READMEs in doc
- Many files in plugins
- Most (all?) files in tools
"git-export-release.sh" is missing:
- ./configure, install-sh, other Autotoolery
- Files generated using Bison/Flex
- help/faq.txt
- packaging/macosx/Info.plist
- plugins/*/plugin.c
- ui/*/*shark-tap-register.c
It looks like you can't build from a "dist" tarball using CMake which is
something we should fix.
"Git-export-release" picks up everything in "images". I'm not sure if
this is desired or not but it's something we haven't done in the past.