Wireshark-dev: Re: [Wireshark-dev] [PATCH] reduce scope of and close a file descriptor in wsuti

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Mon, 9 Jun 2014 13:57:34 -0700
On Jun 9, 2014, at 1:43 PM, Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> wrote:

> On Mon, Jun 09, 2014 at 07:32:49PM +0200, Toralf Förster wrote:
> 
>> +        ws_close(f);
> 
>           ^^^ fclose(f) ?

Yes.

> ws_close() seems to be taking file descriptor.

Yes, it's just a #define for close on UN*X and for _close on Windows.  A FILE * is, obviously, closed by fclose() on all OSes, so no need for ws_fclose().