[Michal Orynicz <michal.orynicz@xxxxxxxxx>]

Personally, I'd think that it should fail, as the features that were specified to be active cannot be activated. This way the user is forced to consciously change desired configuration to one not containing the packages, or install the required packages.

On the other hand, we could just make CMake turn off the features which findpackage could not find.

On 1 May 2014 18:14, Evan Huus <eapache@xxxxxxxxx> wrote:

As of gfbd3c937989c7622815d3019538ca4b7d5a58e27 the cmake build fails if you specify an optional dependency (such as libsbc) and it can't be found. This is causing the buildbot cmake step to fail, since it specifies both YAPP and SBC, which are not present.

I'm not sure how autofoo behaves here; should cmake only be failing if the package is strictly necessary (e.g. glib) or should the buildbot stop asking for dependencies it doesn't have?

Evan

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe

--

Pozdrawiam / Best regards
Michał Orynicz, Software Engineer

Tieto Corporation

Product Development Services

http://www.tieto.com / http://www.tieto.pl
---
ASCII: Michal Orynicz
location: Swobodna 1 Street, 50-088 Wrocław, Poland
room: 5.01 (desk next to 5.08)
---
Please note: The information contained in this message may be legally
privileged and confidential and protected from disclosure. If the
reader of this message is not the intended recipient, you are hereby
notified that any unauthorised use, distribution or copying of this
communication is strictly prohibited. If you have received this
communication in error, please notify us immediately by replying to
the message and deleting it from your computer. Thank You.
---
Please consider the environment before printing this e-mail.
---
Tieto Poland spółka z ograniczoną odpowiedzialnością z siedzibą w
Szczecinie, ul. Malczewskiego 26. Zarejestrowana w Sądzie Rejonowym
Szczecin-Centrum w Szczecinie, XIII Wydział Gospodarczy Krajowego
Rejestru Sądowego pod numerem 0000124858. NIP: 8542085557. REGON:
812023656. Kapitał zakładowy: 4 271500 PLN