Wireshark-dev: [Wireshark-dev] Path to NSIS in config.nmake

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
Date: Wed, 19 Mar 2014 13:30:44 +0000
A recent question on Ask Wireshark (http://ask.wireshark.org/questions/30890/makensis-makensis-path)

Gerald made a change (https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commitdiff;h=dc87fa2d68a5dbc7693b5cc93e044a62af5ce39c) to set the NSIS path, but I'm a bit puzzled by it.

On all the 64 bit systems I have, the env var PROGRAMW6432 is set to "%SystemDrive%\Program Files", so it appears to me that the change, despite the added comment to config.nmake, doesn't look for makensis.exe in "%SystemDrive%\Program Files (x86)" at all.

The nsis installer will default to "%SystemDir%\Program Files (x86)", so I think the second check should use the env var ProgramFiles(x86), which again on all my 64 bit systems points to the default nsis install location.

Thoughts anyone?