Wireshark-dev: Re: [Wireshark-dev] 3GPP 23.038 encoding and string length

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Pascal Quantin <pascal.quantin@xxxxxxxxx>
Date: Tue, 24 Dec 2013 21:45:15 +0100
2013/12/24 Guy Harris <guy@xxxxxxxxxxxx>

On Dec 24, 2013, at 5:30 AM, mmann78@xxxxxxxxxxxx wrote:

> Isn't it simple enough to add a proto_tree_add_gsm_sms_item (or similar) API

We already have tvbuff and proto_tree_ routines that take bit offsets and bit counts, so this may be another case where the regular routines don't work; a routine to handle TS 23.038 encoding, taking a *bit* offset and a count of *characters*, might be the best solution here.

I'd vote for proto_tree_add_ts_23_038_item(), though - that encoding isn't used only in the GSM/3GPP/LTE version of SMS.

I would vote for proto_tree_add_gsm_7bits_item() as TS 23.038 talks about 8 bits data and UCS2 encoding also and defines this alphabet as GSM 7bit. We should not put SMS in its name as it has a much wider use in 3GPP / 3GPP2.

Pascal.