Wireshark-dev: [Wireshark-dev] Is this patch to semcheck.c valid (handling FT_SYSTEM_ID) ?

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
Date: Mon, 23 Dec 2013 17:42:29 +0000
My gcc build is complaining that FT_SYSTEM_ID is missing from 3 switch statements.  I'm not sure I properly understand how it is used, so would appreciate if someone could take a quick look at this patch?  If there are no objections I will commit it later...

Thanks,
Martin
Index: semcheck.c
===================================================================
--- semcheck.c	(revision 54393)
+++ semcheck.c	(working copy)
@@ -65,6 +65,7 @@
 	switch (a) {
 		case FT_NONE:
 		case FT_PROTOCOL:
+		case FT_SYSTEM_ID:
 		case FT_FLOAT:		/* XXX - should be able to compare with INT */
 		case FT_DOUBLE:		/* XXX - should be able to compare with INT */
 		case FT_ABSOLUTE_TIME:
@@ -172,6 +173,7 @@
 	switch(hfinfo->type) {
 		case FT_NONE:
 		case FT_PROTOCOL:
+		case FT_SYSTEM_ID:
 		case FT_FLOAT:
 		case FT_DOUBLE:
 		case FT_ABSOLUTE_TIME:
@@ -304,6 +306,7 @@
 
 		case FT_NONE:
 		case FT_PROTOCOL:
+		case FT_SYSTEM_ID:
 		case FT_FLOAT:
 		case FT_DOUBLE:
 		case FT_ABSOLUTE_TIME: