On Nov 24, 2013, at 11:45 AM, Graham Bloice <graham.bloice@xxxxxxxxxxxxx> wrote:
> • As mentioned in my previous message, the VS solution chops out every 8192nd byte from the command line passed to make-dissector-reg.py. My patch (make-reg.patch) gets CMake to write out the required source file list to a file and modifies the python script to read in the file. The python changes *should* be backwards compatible.
...but they aren't:
Making register.c with python
../../tools/make-dissector-reg.py:72: Warning: 'with' will become a reserved keyword in Python 2.6
File "../../tools/make-dissector-reg.py", line 72
with open(sys.argv[3]) as f:
^
SyntaxError: invalid syntax
This is on the buildbot that's building the 10.5 version of Wireshark (i.e., the build on that buildbot is broken); the buildbot is running 10.6, and I infer from
PYTHONPATH=/Library/Python/2.5/site-packages
that it's using Python 2.5.
"Warning: 'with' will become a reserved keyword in Python 2.6" presumably means it's not a reserved keyword in Python 2.5; perhaps that means it's not supported in 2.5, in which case you can't use it in a Python script in the build procedure unless we choose to require Python 2.6, not just Python 2.5 (as we do now).