Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 53473: /trunk/ui/ /trunk/ui/gtk/: main_menubar.c /trunk/

Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 53473: /trunk/ui/ /trunk/ui/gtk/: ma

From: Guy Harris <guy@xxxxxxxxxxxx>

Date: Thu, 21 Nov 2013 11:30:35 -0800

On Nov 21, 2013, at 11:28 AM, Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> wrote:

> I'd rather use proto_get_id_by_filter_name() in some init function, and later compare.
> 
> Making variables extern is somehow tempting, like we could extern dissector handles and stop using find_dissector() ;]
> But I think it's wrong way.

+1 (as one might infer from my previous message)

References:
- Re: [Wireshark-dev] [Wireshark-commits] rev 53473: /trunk/ui/ /trunk/ui/gtk/: main_menubar.c /trunk/ui/qt/: main_window_slots.cpp
  - From: Evan Huus
- Re: [Wireshark-dev] [Wireshark-commits] rev 53473: /trunk/ui/ /trunk/ui/gtk/: main_menubar.c /trunk/ui/qt/: main_window_slots.cpp
  - From: mmann78
- Re: [Wireshark-dev] [Wireshark-commits] rev 53473: /trunk/ui/ /trunk/ui/gtk/: main_menubar.c /trunk/ui/qt/: main_window_slots.cpp
  - From: Evan Huus
- Re: [Wireshark-dev] [Wireshark-commits] rev 53473: /trunk/ui/ /trunk/ui/gtk/: main_menubar.c /trunk/ui/qt/: main_window_slots.cpp
  - From: Jakub Zawadzki