Wireshark-dev: Re: [Wireshark-dev] follow_stream_dialog.cpp warning turning error

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Gerald Combs <gerald@xxxxxxxxxxxxx>
Date: Tue, 15 Oct 2013 08:24:11 -0700
On 10/14/13 10:18 PM, Joerg Mayer wrote:
> [ 71%] Building CXX object ui/qt/CMakeFiles/qtui.dir/follow_stream_dialog.cpp.o
> /home/jmayer/work/wireshark/svn/trunk/ui/qt/follow_stream_dialog.cpp: In member function ‘virtual void FollowStreamDialog::keyPressEvent(QKeyEvent*)’:
> /home/jmayer/work/wireshark/svn/trunk/ui/qt/follow_stream_dialog.cpp:519:65: error: suggest parentheses around ‘&&’ within ‘||’ [-Werror=parentheses]
>      if (event->key() == Qt::Key_F3 || event->key() == Qt::Key_N && event->modifiers() & Qt::ControlModifier) {
>                                                                  ^
> cc1plus: all warnings being treated as errors
> make[2]: *** [ui/qt/CMakeFiles/qtui.dir/follow_stream_dialog.cpp.o] Error 1
> make[1]: *** [ui/qt/CMakeFiles/qtui.dir/all] Error 2

Fixed in r52620.