Maynard, Chris skrev 2013-10-15 00:47:
Why not add a fence so it's always visible then?
My point is that I don't want to write column info in the VLAN dissector
to speed up dissection. If it could
be arranged to only write the "last" entry that will actually be in the
packet list or written out by tshark it would be much more efficient.
One option is to only write to columns if next dissector isn't found in
the cases where that is possible.
In the reference trace I'm pursuing col_add_fstr() costs 7.52 is called
4,7 million times, where of 2.8 million times is from the VLAN dissector.
Regards
Anders
-----Original Message-----
From: wireshark-commits-bounces@xxxxxxxxxxxxx [mailto:wireshark-commits-bounces@xxxxxxxxxxxxx] On Behalf Of etxrab@xxxxxxxxxxxxx
Sent: Monday, October 14, 2013 5:51 PM
To: wireshark-commits@xxxxxxxxxxxxx
Subject: [Wireshark-commits] rev 52608: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-vlan.c
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=52608
User: etxrab
Date: 2013/10/14 09:50 PM
Log:
Reverting as requested by Jakub, eventhoug I don't think this prticular entry is useful as it's duplicated in the tree and almost certanly never vissible.
Directory: /trunk/epan/dissectors/
Changes Path Action
+0 -3 packet-vlan.c Modified